| commit | fefda1abda0b8b7ada7be0c47594528770c4c162 | [log] [tgz] |
|---|---|---|
| author | Dmitri Shuralyov <dmitshur@golang.org> | Mon Oct 21 11:59:22 2024 -0400 |
| committer | Gopher Robot <gobot@golang.org> | Mon Oct 21 18:16:43 2024 +0000 |
| tree | 5fc8cfe42c29b65fda9ba7662729ccd82117ae02 | |
| parent | a457f47ba270b8aaa55d617b739beaee4233b2a0 [diff] |
internal/texttest: remove Run and Bench helpers
Versions of Go whose testing package doesn't yet support subtests and
sub-benchmarks are no longer supported. Drop an intermediate layer of
compatibility from the ./internal/texttest package.
The initial version of this change was git-generate'd with the script:
rm internal/testtext/go1_{6,7}.go
gofmt -r 'testtext.Run(t, n, f) -> t.Run(n, f)' -w .
gofmt -r 'testtext.Bench(b, n, f) -> b.Run(n, f)' -w .
goimports -w .
Unfortunately it seems gofmt -r dropped inner comments inside f, and
also added some spurious blank lines. So it was manually amended not
to include those changes.
Change-Id: I5bcb553b90ce392aada7896d576194be479f2616
Reviewed-on: https://go-review.googlesource.com/c/text/+/621575
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This repository holds supplementary Go libraries for text processing, many involving Unicode.
It is important that the Unicode version used in x/text matches the one used by your Go compiler. The x/text repository supports multiple versions of Unicode and will match the version of Unicode to that of the Go compiler. At the moment this is supported for Go compilers from version 1.7.
The easiest way to install is to run go get -u golang.org/x/text. You can also manually git clone the repository to $GOPATH/src/golang.org/x/text.
To submit changes to this repository, see http://golang.org/doc/contribute.html.
To generate the tables in this repository (except for the encoding tables), run go generate from this directory. By default tables are generated for the Unicode version in core and the CLDR version defined in golang.org/x/text/unicode/cldr.
Running go generate will as a side effect create a DATA subdirectory in this directory, which holds all files that are used as a source for generating the tables. This directory will also serve as a cache.
Run
go test ./...
from this directory to run all tests. Add the “-tags icu” flag to also run ICU conformance tests (if available). This requires that you have the correct ICU version installed on your system.
TODO:
To generate the tables in this repository (except for the encoding tables), run go generate from this directory. By default tables are generated for the Unicode version in core and the CLDR version defined in golang.org/x/text/unicode/cldr.
Running go generate will as a side effect create a DATA subdirectory in this directory which holds all files that are used as a source for generating the tables. This directory will also serve as a cache.
To update a Unicode version run
UNICODE_VERSION=x.x.x go generate
where x.x.x must correspond to a directory in https://www.unicode.org/Public/. If this version is newer than the version in core it will also update the relevant packages there. The idna package in x/net will always be updated.
To update a CLDR version run
CLDR_VERSION=version go generate
where version must correspond to a directory in https://www.unicode.org/Public/cldr/.
Note that the code gets adapted over time to changes in the data and that backwards compatibility is not maintained. So updating to a different version may not work.
The files in DATA/{iana|icu|w3|whatwg} are currently not versioned.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the image repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/text:” in the subject line, so it is easy to find.