tree c2f18ef013b6290e778d026a30429c9f62cdfd09
parent ab07ad1b65bc4cdc738e747f7569a3795d2e60ec
author Il Harper <afanyiyu@gmail.com> 1668805182 +0800
committer Gopher Robot <gobot@golang.org> 1689874185 +0000

cmd/gotext: fix misbehaviors

The existing implementation has misbehaviors described in golang/go#56842:

- `gotext extract` ignores `lang` flag
- `gotext generate` ignores `out` flag
- Misbehavior of `gotext generate` when no flag specified

This commit fixes these bugs:

- Update `Command.UsageLine` for `cmdGenerate`
- Fix flag misbehaviors by encapsuling flag definition statements into individual `Command.Init()` functions of commands
- Fix `gotext generate` misbehavior by executing `pipeline.State.Merge()` before `pipeline.State.Generate()`

Fixes golang/go#56842

Change-Id: Id5e324b573b2b389bec22181482a97445230d0cc
Reviewed-on: https://go-review.googlesource.com/c/text/+/452115
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>