Google Git
Sign in
go / term / 189f313d0caebef915a85507ed977b82d46bc2df
commit189f313d0caebef915a85507ed977b82d46bc2df[log] [tgz]
authorYasuhiro Matsumoto <mattn.jp@gmail.com>Wed Jan 24 12:37:23 2018 +0900
committerAlex Brainman <alex.brainman@gmail.com>Fri Jan 26 02:30:34 2018 +0000
tree8a397a79c14ef0a30e6a1e0f6994518eb82658a0
parentf344d0325d325b8614653a12bb045ff8f12efdd9 [diff]
ssh/terminal: use duplicate handle in ReadPassword

os.NewFile assigns finalizer to close file handle
passed into ReadPassword. But that is not expected.
Make a duplicate of original file handle, and pass
copy handle into ReadPassword instead.

Fixes golang/go#23525

Change-Id: I4d6725e9a1cc20defd1b58afc383e35a7f9ee4e9
Reviewed-on: https://go-review.googlesource.com/89395
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
1 file changed
tree: 8a397a79c14ef0a30e6a1e0f6994518eb82658a0
  1. terminal.go
  2. terminal_test.go
  3. util.go
  4. util_bsd.go
  5. util_linux.go
  6. util_plan9.go
  7. util_solaris.go
  8. util_windows.go