Google Git
Sign in
go / term / a21c5dde4c267671d53b40583e43e936a684a466
commita21c5dde4c267671d53b40583e43e936a684a466[log] [tgz]
authorYasuhiro Matsumoto <mattn.jp@gmail.com>Wed Nov 22 18:46:40 2017 +0900
committerAlex Brainman <alex.brainman@gmail.com>Fri Nov 24 09:08:02 2017 +0000
treede631becb41c3e8cdcd6a3acf39ddbf46e93ae95
parenta1a083ff5a00a76e37065c806c0d330fc2f7979b [diff]
ssh/terminal: handle non-ASCII characters when reading passwords

ReadPassword uses Windows ReadFile to read from console handle.
But ReadFile does not split input into UTF-8 characters, so ReadFile
only works when input is ASCII. Use os.File instead of Windows
ReadFile, because os.File reads console and parses it into UTF-8.

Fixes golang/go#22828

Change-Id: Ifeed3e8048b51f46706c28d4154a3e4b10111a3e
Reviewed-on: https://go-review.googlesource.com/79335
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
1 file changed
tree: de631becb41c3e8cdcd6a3acf39ddbf46e93ae95
  1. terminal.go
  2. terminal_test.go
  3. util.go
  4. util_bsd.go
  5. util_linux.go
  6. util_plan9.go
  7. util_solaris.go
  8. util_windows.go