tree 0893bdcce0bd90e1bea0de51eb5b33efd0b45155
parent 9ff3ad9b3e6802ed3bbc6ef4939986eabab5216b
author Rob Findley <rfindley@google.com> 1715884376 +0000
committer Robert Findley <rfindley@google.com> 1715885936 +0000

start: when upload && !crashmonitor.Supported(), don't use crashmonitor

CL 585416 in x/tools changed gopls to call telemetry.Start with both
Upload and ReportCrashes, but a bug in the telemetry.Start logic
resulted in crashmonitor.Parent being called even when
!crashmonitor.Supported(), due to a standard disjoint condition error.

Fix this by consolidating all handling of telemetry.Config into
telemetry.Start, and passing in the derived predicates.

For golang/go#67430

Change-Id: I2cb4eeae0c98e295af6d531a94090a401f8d0103
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/586195
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>