tree 611bbd0fcd7a13dca9fbd9f16ad002e3f0fcf6c5
parent b6b8557e8e2974925aec7a136ba0e323eedc5f43
author Yiftach Karkason <yiftach@island.io> 1790020383 +0300
committer Gopher Robot <gobot@golang.org> 1791577767 -0700

windows/mkwinsyscall: read 32-bit results from the low half of the return register

On 64-bit Windows the upper 32 bits of the return register are
undefined for 32-bit return types (BOOL, DWORD, LSTATUS, NTSTATUS,
HRESULT). Hooked or otherwise non-conforming implementations can leave
garbage there, which the generated code then mistook for a failure or
for a different error code.

Read error and bool results through uint32 so only the defined bits are
used, including the default failure check of functions that only return
err. Other return values are left as declared.

Add a test that builds a DLL wrapping RegOpenKeyExW (DWORD retval),
IsValidCodePage (BOOL retval) and GetHandleInformation (BOOL retval
with err) so their results come back with garbage in the upper half of
the register, and checks that the generated wrappers ignore it.

Fixes golang/go#81249

Change-Id: I1e4cd3aee945cf32c79032745505ed25dd455857
Reviewed-on: https://go-review.googlesource.com/c/sys/+/836325
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Damien Neil <dneil@google.com>