| commit | 4b90ce9b60b31bd0d0cbceb17532b5c810912f88 | [log] [tgz] |
|---|---|---|
| author | Alex Brainman <alex.brainman@gmail.com> | Sat Aug 01 18:10:44 2020 +1000 |
| committer | Alex Brainman <alex.brainman@gmail.com> | Sun Aug 02 09:19:54 2020 +0000 |
| tree | ad66f3536b09763f0ec919778add86b3573a3b52 | |
| parent | 3e129f6d46b10b0e1da36b3deffcb55e09631b64 [diff] |
windows/svc: align stack in servicemain before calling syscall I noticed that we call syscall in servicemain without aligning stack. That is against Windows rules, so align the stack as required. I tried running this code with specifically non-aligned stack (I aligned stack, and then subtracted 1 from SP) on my Windows 10 to test this change. But it makes no difference on my Windows 10 PC - I built and run golang.org/x/sys/windows/svc/example, and it runs successfully regardless of stack alignment. But alignment might make difference on other computers. Maybe fixes golang/go#40160 Change-Id: I351f7f730fba4aa6dc409a79de4ad737b4a0a7d4 Reviewed-on: https://go-review.googlesource.com/c/sys/+/246317 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
This repository holds supplemental Go packages for low-level interactions with the operating system.
The easiest way to install is to run go get -u golang.org/x/sys. You can also manually git clone the repository to $GOPATH/src/golang.org/x/sys.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the sys repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/sys:” in the subject line, so it is easy to find.