commit d684c6f886692f8b63049d3dabe4f1911ae979c3
author Sebastiaan van Stijn <github@gone.nl> Thu Nov 10 18:59:02 2022 +0000
committer Gopher Robot <gobot@golang.org> Thu Nov 10 21:11:17 2022 +0000
tree ed1e386351cfcaeab7935e06bdb7a1a7ba2bbc9c
parent fc697a31fa06b616162e34fd66047ab52722ba6c

execabs: isGo119ErrDot: use errors.Is instead of string-matching

Addresses the TODO added in CL 403256.

Change-Id: Iae44242e00b6a309cc0f1e336462bc2d4995a5e2
GitHub-Last-Rev: 1adfdb799489c068127e5088cd131dcca79d86df
GitHub-Pull-Request: golang/sys#142
Reviewed-on: https://go-review.googlesource.com/c/sys/+/448877
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>

execabs/execabs_go119.go

diff --git a/execabs/execabs_go119.go b/execabs/execabs_go119.go
index 1e7a9ad..46c5b52 100644
--- a/execabs/execabs_go119.go
+++ b/execabs/execabs_go119.go
@@ -7,9 +7,11 @@
 
 package execabs
 
-import "strings"
+import (
+	"errors"
+	"os/exec"
+)
 
 func isGo119ErrDot(err error) bool {
-	// TODO: return errors.Is(err, exec.ErrDot)
-	return strings.Contains(err.Error(), "current directory")
+	return errors.Is(err, exec.ErrDot)
 }