commit c23410a886927bab8ca5e80b08af6a56faeb330d
author Tobias Klauser <tklauser@distanz.ch> Fri Jun 23 13:49:42 2017 +0200
committer Ian Lance Taylor <iant@golang.org> Fri Jun 23 14:22:15 2017 +0000
tree 33cadeb7f317cc76970279e88a6bb899e5499f97
parent fb4cac33e3196ff7f507ab9b2d2a44b0142f5b5a

unix: check Fchmodat flags parameter on Linux

Currently Linux' fchmodat(2) syscall implementation doesn't support the
flags parameter (though it might in future versions [1]). Fchmodat in
x/sys/unix takes the parameter and (wrongly) passes it on to the syscall
which will ignore it.

According to the POSIX.1-2008 manual page [2], AT_SYMLINK_NOFOLLOW is
the only valid value for the flags parameter and EOPNOTSUPP should be
returned in case changing the mode of a symbolic link is not supported
by the underlying system.  EINVAL should be returned for any other value
of the flags parameter.

  [1] https://patchwork.kernel.org/patch/9596301/
  [2] http://pubs.opengroup.org/onlinepubs/9699919799/functions/chmod.html

Change the Fchmodat implementation accordingly and also add the
corresponding test.

Fixes golang/go#20130

Change-Id: I62e677e6674d3702eaf388af0ac3d7e623a35c24
Reviewed-on: https://go-review.googlesource.com/46474
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>