| commit | 04d7465088b8adeccf882a9ae1e0423323c7bd9d | [log] [tgz] |
|---|---|---|
| author | Jason A. Donenfeld <Jason@zx2c4.com> | Thu Jan 21 15:17:19 2021 +0100 |
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | Fri Jan 22 09:31:01 2021 +0000 |
| tree | e4f95bea9bf4d472f79fd926522e8efdad791e5d | |
| parent | b64e53b001e413bd5067f36d4e439eded3827374 [diff] |
windows: correct signature of recently added GetWindowThreadProcessId This function returns 0 and sets last error on failure. While this isn't said explicitly on MSDN, there's no PID 0, and trivial reverse engineering shows that this is the case. For example: .text:00000001800035ED loc_1800035ED: ; CODE XREF: GetWindowThreadProcessId+23↑j .text:00000001800035ED ; GetWindowThreadProcessId+3D↑j ... .text:00000001800035ED mov ecx, 578h ; LastError .text:00000001800035F2 call cs:__imp_RtlSetLastWin32Error .text:00000001800035F9 nop dword ptr [rax+rax+00h] .text:00000001800035FE .text:00000001800035FE loc_1800035FE: ; CODE XREF: GetWindowThreadProcessId+65↑j .text:00000001800035FE xor eax, eax .text:0000000180003600 jmp short loc_1800035AA This function was also just added by a user who is likely its only consumer, so this error is not too late to fix. Change-Id: I5dd24e78c006686bb8f1288ad0fe63cd67df56a6 Reviewed-on: https://go-review.googlesource.com/c/sys/+/285272 Trust: Jason A. Donenfeld <Jason@zx2c4.com> Trust: Alex Brainman <alex.brainman@gmail.com> Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
This repository holds supplemental Go packages for low-level interactions with the operating system.
The easiest way to install is to run go get -u golang.org/x/sys. You can also manually git clone the repository to $GOPATH/src/golang.org/x/sys.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the sys repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/sys:” in the subject line, so it is easy to find.