| commit | 90c8f94a055257f9ab343137cbada4e658750fbb | [log] [tgz] |
|---|---|---|
| author | Bryan C. Mills <bcmills@google.com> | Mon Feb 06 11:48:46 2023 -0500 |
| committer | Gopher Robot <gobot@golang.org> | Tue Feb 07 00:05:19 2023 +0000 |
| tree | 3a7de46ab2518439f108a97d6010ddb55c25c4cc | |
| parent | 4e121b1efb52d0ccc0c89c55272b7c3da9a475f8 [diff] |
unix: avoid converting non-pointers to unsafe.Pointer in PtraceIO Despite having the misleading type "void*" in the C API, the "offs" field of the ptrace_io_desc struct is an offset within the child process, and thus is not necessarily a valid pointer at all in the parent process. The Go unsafe.Pointer type must refer only to valid pointers, so converting this field through unsafe.Pointer is incorrect and (in some cases) dangerous. While we're here, let's also rename the "addr" function argument to "offs", since that's the corresponding ptrace_io_desc field. It's very confusing to have a function argument named "attr" that doesn't map to the struct field of the same name! For golang/go#58351. Change-Id: Id899f823e8d398b51fb0c42f466d7ae2f957c26b Reviewed-on: https://go-review.googlesource.com/c/sys/+/465675 Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
This repository holds supplemental Go packages for low-level interactions with the operating system.
The easiest way to install is to run go get -u golang.org/x/sys. You can also manually git clone the repository to $GOPATH/src/golang.org/x/sys.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the sys repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/sys:” in the subject line, so it is easy to find.