| commit | 78d5f264b493f125018180c204871ecf58a2dce1 | [log] [tgz] |
|---|---|---|
| author | Alex Brainman <alex.brainman@gmail.com> | Sun Apr 29 18:56:08 2018 +1000 |
| committer | Alex Brainman <alex.brainman@gmail.com> | Tue May 01 09:27:40 2018 +0000 |
| tree | 6fd8fb7af335cc60f4176417d01af99b206e4c09 | |
| parent | 4adea008a5e5f820b6028611ae0b6b3fbcec534b [diff] |
windows/svc: correct MOVL instruction in sys_amd64.s Second argument of servicemain is a pointer. See https://msdn.microsoft.com/en-us/library/windows/desktop/ms685138(v=vs.85).aspx So amd64 assembler code should use MOVQ to read that value. I probably copied 386 assembler code into amd64 and did not adjust the code. Broken code was used to pass parameters to the service, so add some tests to verify that parameter passing works. Fixes golang/go#24575 Change-Id: I89f8cad026ea13f8a5d78ff3e24b7236e27fc91f Reviewed-on: https://go-review.googlesource.com/110160 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This repository holds supplemental Go packages for low-level interactions with the operating system.
The easiest way to install is to run go get -u golang.org/x/sys. You can also manually git clone the repository to $GOPATH/src/golang.org/x/sys.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the sys repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/sys:” in the subject line, so it is easy to find.