| commit | 71da6904945ac440253cb5c132d64712f80ca497 | [log] [tgz] |
|---|---|---|
| author | Davis Goodin <dagood@microsoft.com> | Mon Jan 23 14:48:25 2023 -0800 |
| committer | Alex Brainman <alex.brainman@gmail.com> | Mon Jan 30 19:10:05 2023 +0000 |
| tree | 4ed40ed56ffa833950a606a0f37ef827da97856f | |
| parent | b829a39df56d401e6c7493c6cef2bf3880335626 [diff] |
windows/mkwinsyscall: support "." and "-" in DLL name This change adds "." and "-" support for DLL filenames in "//sys". Supporting "." requires a change in how mkwinsyscall handles the "= <filename>.<function>" syntax. Instead of assuming that only one "." can appear in this string, now mkwinsyscall assumes that any additional "." belongs to the filename. Supporting "." also requires changing how Go identifiers are created for each DLL. This change also allows mkwinsyscall to support "-". When creating a Go identifier, "." and "-" in the DLL filename are replaced with "_". Otherwise, mkwinsyscall would produce invalid Go code, causing "format.Source" to fail. Includes a test for the new behavior. There aren't yet any cases where this code is executed while generating the x/sys/windows syscalls. The syscalls "SetSocketMediaStreamingMode" from "windows.networking.dll" and "WslRegisterDistribution" from "api-ms-win-wsl-api-l1-1-0.dll" can be successfully called using this change, but these syscalls have no known use in Go so they are not included in this change. Fixes golang/go#57913 Change-Id: If64deeb8c7738d61520e7392fd2d81ef8920f08d Reviewed-on: https://go-review.googlesource.com/c/sys/+/463215 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Run-TryBot: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Quim Muntal <quimmuntal@gmail.com> Reviewed-by: Bryan Mills <bcmills@google.com>
This repository holds supplemental Go packages for low-level interactions with the operating system.
The easiest way to install is to run go get -u golang.org/x/sys. You can also manually git clone the repository to $GOPATH/src/golang.org/x/sys.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the sys repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/sys:” in the subject line, so it is easy to find.