| commit | 111129e158e253c67594dc4ea20d2e600aec2534 | [log] [tgz] |
|---|---|---|
| author | Boshi Lian <farmer1992@gmail.com> | Sun Nov 29 13:33:00 2020 +0000 |
| committer | Alex Brainman <alex.brainman@gmail.com> | Mon Nov 30 07:27:48 2020 +0000 |
| tree | 6ef77edf3f1fbfddc39e8b7c11552a47e4761753 | |
| parent | 77190671981848ff71219ecfff38636c9add3b79 [diff] |
windows: correct CertOpenStore to expect a 0 return value on failure According to [1], this function returns NULL when it errors, rather than INVALID_HANDLE_VALUE, which other Win32 functions return. Quick reversing indicates that [1] is correct, as there's a `xor eax, eax` in the error paths of the function just before jumping to the epilogue. [1] https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-certopenstore#return-value Change-Id: Iafe3b9c78e92c9c5adb8d14a434e11b58f59f19b GitHub-Last-Rev: 5fcd21d88936322645b1ab296309644b85869b87 GitHub-Pull-Request: golang/sys#92 Reviewed-on: https://go-review.googlesource.com/c/sys/+/273446 Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Trust: Alex Brainman <alex.brainman@gmail.com> Trust: Jason A. Donenfeld <Jason@zx2c4.com>
This repository holds supplemental Go packages for low-level interactions with the operating system.
The easiest way to install is to run go get -u golang.org/x/sys. You can also manually git clone the repository to $GOPATH/src/golang.org/x/sys.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the sys repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/sys:” in the subject line, so it is easy to find.