)]}' { "log": [ { "commit": "a8edb3cea8d87f2f2b47a5662b7650823a62ed4d", "tree": "bb7c7988f15e6e972e4e800b7f67ea42ff8fae4d", "parents": [ "4f4de26123f2e46fcc57010c1d781fbd00319d4e" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Aug 19 16:59:35 2026 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Aug 19 10:30:39 2026 -0700" }, "message": "all: upgrade go directive to at least 1.26.0 [generated]\n\nBy now Go 1.27.0 has been released, and Go 1.25 is no longer supported\nper the Go Release Policy (see https://go.dev/doc/devel/release#policy).\n\nSee https://go.dev/doc/godebug#go-126 for GODEBUG setting changes\nrelevant to Go 1.26.\n\nFor golang/go#69095.\n\n[git-generate]\n(cd . \u0026\u0026 go get go@1.26.0 \u0026\u0026 go mod tidy)\n\nChange-Id: I1bdbd99000a6eed1a9c85d7f58c5597272bdc94c\nReviewed-on: https://go-review.googlesource.com/c/review/+/817860\nLUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Carlos Amedee \u003ccarlos@golang.org\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "4f4de26123f2e46fcc57010c1d781fbd00319d4e", "tree": "82672ba4a19d706c18f79d84b8775ff02186171a", "parents": [ "895189e3454ab08aef270dca07a741d76eb01d50" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Sun Aug 16 11:14:17 2026 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@google.com", "time": "Sun Aug 16 20:20:22 2026 -0700" }, "message": "all: remove double space in copyright headers\n\nNot sure how we missed this repo when we changed the convention.\n\nChange-Id: I9dccfcd6119930e3dc72b8ea463c49616a6a6964\nReviewed-on: https://go-review.googlesource.com/c/review/+/816260\nReviewed-by: Russ Cox \u003crsc@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "895189e3454ab08aef270dca07a741d76eb01d50", "tree": "56fff4904bd179d7296742c672e60368c79fe7b6", "parents": [ "55cca39997e216656d703840268b9ff8676b0672" ], "author": { "name": "Paul Jolly", "email": "paul@myitcv.io", "time": "Wed Apr 29 16:57:58 2026 +0100" }, "committer": { "name": "Sean Liao", "email": "sean@liao.dev", "time": "Fri May 01 09:23:38 2026 -0700" }, "message": "git-codereview: isolate tests from user\u0027s global git config\n\nThe test harness creates ephemeral git repositories via gitTest and\nruns commands like \"git tag work\" without a message. When a user has\ntag.gpgsign or commit.gpgsign enabled in their global git config, those\nsettings are inherited by the test repos and cause failures: signed\ntags require a message, so \"git tag work\" aborts with \"fatal: no tag\nmessage?\".\n\nRather than disable the specific settings that bite us today, set\nGIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM to os.DevNull in trun so every\ntest git invocation runs with no global or system config at all. This\nforecloses the entire class of \"user config leaks into tests\" bugs\n(gpg signing, init.defaultBranch, core.autocrlf, custom hooks, signing\nkeys, aliases, ...) instead of stamping out one symptom.\n\nTradeoffs worth noting for the interested reader:\n\n - GIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM were added in git 2.32\n (June 2021), so this raises the minimum git version required to\n run the test suite. The tool itself is unaffected.\n\n - trun is also used for non-git commands; setting these env vars\n unconditionally is harmless because non-git binaries ignore them,\n and keeping the call site unconditional keeps trun simple.\n\n - os.DevNull (rather than a hard-coded \"/dev/null\") is used so the\n isolation works on Windows, where the equivalent path is \"NUL\".\n\nChange-Id: Iafdef28241c81e30cb4f7898da0e5eeb4b7f0872\nReviewed-on: https://go-review.googlesource.com/c/review/+/772280\nReviewed-by: Carlos Amedee \u003ccarlos@golang.org\u003e\nLUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Daniel Martí \u003cmvdan@mvdan.cc\u003e\nReviewed-by: Sean Liao \u003csean@liao.dev\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "55cca39997e216656d703840268b9ff8676b0672", "tree": "f02a192d0f515e2d97ac5eb858c27bb51290f1b8", "parents": [ "e25212f51b9f1689197321405a3c62cd38eaea45" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Feb 11 18:54:12 2026 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Feb 11 11:12:22 2026 -0800" }, "message": "all: upgrade go directive to at least 1.25.0 [generated]\n\nBy now Go 1.26.0 has been released, and Go 1.24 is no longer supported\nper the Go Release Policy (see https://go.dev/doc/devel/release#policy).\n\nSee go.dev/doc/godebug#go-125 for GODEBUG changes relevant to Go 1.25.\n\nFor golang/go#69095.\n\n[git-generate]\n(cd . \u0026\u0026 go get go@1.25.0 \u0026\u0026 go mod tidy)\n\nChange-Id: Id20bf062485b95401ad2d5db8054a0a396ca255c\nReviewed-on: https://go-review.googlesource.com/c/review/+/744660\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Junyang Shao \u003cshaojunyang@google.com\u003e\n" }, { "commit": "e25212f51b9f1689197321405a3c62cd38eaea45", "tree": "ef2571440c978c92e0869ba2097eb88db387c2d0", "parents": [ "b313cd9402503ea9ae851855a00bff2e45c50655" ], "author": { "name": "matloob@golang.org", "email": "matloob@golang.org", "time": "Wed Nov 05 15:27:48 2025 -0500" }, "committer": { "name": "Michael Matloob", "email": "matloob@golang.org", "time": "Fri Nov 07 13:59:04 2025 -0800" }, "message": "git-codereview: add matloob@google.com to the mail shortOptOut list\n\nSo that matloob@golang.org is preferred for git codereview mail -r matloob.\n\nChange-Id: I6a6a69643230e022605905c88334a9f865f5ba13\nReviewed-on: https://go-review.googlesource.com/c/review/+/718240\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Michael Pratt \u003cmpratt@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "b313cd9402503ea9ae851855a00bff2e45c50655", "tree": "7b315f5755c39c41fc191ed2041aef6b032758b5", "parents": [ "76393d655c8f354421be1040adf3ce5f4ea322f0" ], "author": { "name": "cuishuang", "email": "imcusg@gmail.com", "time": "Tue Oct 21 10:35:27 2025 +0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Oct 24 09:37:34 2025 -0700" }, "message": "git-codereview: fix some comments\n\nChange-Id: I0650c81a855138049e9132d56cc742620ecaf185\nReviewed-on: https://go-review.googlesource.com/c/review/+/713362\nReviewed-by: Sean Liao \u003csean@liao.dev\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Sean Liao \u003csean@liao.dev\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "76393d655c8f354421be1040adf3ce5f4ea322f0", "tree": "3f2648704bc953584d8bf4c35f570fd05e75d130", "parents": [ "48aa97b42827239f9fd02d1b5ad75adc200c7a72" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Aug 13 14:21:46 2025 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Aug 13 07:45:59 2025 -0700" }, "message": "all: upgrade go directive to at least 1.24.0 [generated]\n\nBy now Go 1.25.0 has been released, and Go 1.23 is no longer supported\nper the Go Release Policy (see https://go.dev/doc/devel/release#policy).\n\nFor golang/go#69095.\n\n[git-generate]\n(cd . \u0026\u0026 go get go@1.24.0 \u0026\u0026 go mod tidy \u0026\u0026 go fix ./... \u0026\u0026 go mod edit -toolchain\u003dnone)\n\nChange-Id: I2027bac1da172f9a103b6608707d65de65cc1f3c\nReviewed-on: https://go-review.googlesource.com/c/review/+/695735\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "48aa97b42827239f9fd02d1b5ad75adc200c7a72", "tree": "60f37a646805ad81076b21ed4e0b1281dcc4524b", "parents": [ "c4af2b031e13e282462ea8ae4311bfabe115ae9d" ], "author": { "name": "Matt T. Proud", "email": "matt.proud@gmail.com", "time": "Fri Jul 04 20:03:02 2025 +0200" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Jul 09 08:35:44 2025 -0700" }, "message": "git-codereview: frame sync as git codereview sync\n\nThe codereview binary referred to the sync subcommand as merely \"git\nsync\" in a number of places in user surfaces. This was wrong and\nmisleading, so the code now refers to it with the codereview parent\nsubcommand in the name (i.e., a \"git codereview sync\").\n\nChange-Id: Icf3f96a8c76b57319bc3101b3e9fd0cbd8cecea9\nReviewed-on: https://go-review.googlesource.com/c/review/+/685855\nAuto-Submit: Sean Liao \u003csean@liao.dev\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Carlos Amedee \u003ccarlos@golang.org\u003e\nReviewed-by: Sean Liao \u003csean@liao.dev\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\n" }, { "commit": "c4af2b031e13e282462ea8ae4311bfabe115ae9d", "tree": "f9bbfdebdd23b2e0c3fe3c838abfb6f6849211bf", "parents": [ "d5c513ca99314c64746d8c23dd8c126b9dbb3823" ], "author": { "name": "Adam Bender", "email": "abender@gmail.com", "time": "Wed Jun 11 19:12:34 2025 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Jun 17 10:40:36 2025 -0700" }, "message": "git-codereview: explicitly include the codereview subcommand in suggested commands\n\nIf a user does not have the recommended aliases in their .gitconfig, the suggested\ncommand will not work. Several suggestions have the codereview subcommand already;\nthis change updates all suggestions to include it.\n\nChange-Id: I3613f24172c2d90a7038f263cad93cbdcddbbbca\nReviewed-on: https://go-review.googlesource.com/c/review/+/681176\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Junyang Shao \u003cshaojunyang@google.com\u003e\nReviewed-by: Sean Liao \u003csean@liao.dev\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nAuto-Submit: Sean Liao \u003csean@liao.dev\u003e\n" }, { "commit": "d5c513ca99314c64746d8c23dd8c126b9dbb3823", "tree": "ce54fc919754aa579b1f7a21d9709212b63199a6", "parents": [ "44a75e6d7c7357094e78043f8786f4ad11fc811b" ], "author": { "name": "Anatoli Babenia", "email": "anatoli@rainforce.org", "time": "Thu Apr 10 20:07:28 2025 +0300" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Apr 11 08:16:03 2025 -0700" }, "message": "git-codereview: do not write hooks if -n is given\n\nFixes golang/go#73314\n\nChange-Id: I881c2ae97f72990a6daac4919687f85cb24ac076\nReviewed-on: https://go-review.googlesource.com/c/review/+/664555\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nTryBot-Bypass: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nReviewed-by: Carlos Amedee \u003ccarlos@golang.org\u003e\n" }, { "commit": "44a75e6d7c7357094e78043f8786f4ad11fc811b", "tree": "3960166713753787a1e67247a7dc310cde818f0c", "parents": [ "53e0267ad4a55f61f94f167e38ccfa2aa7970662" ], "author": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Feb 14 21:16:42 2025 +0000" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Feb 14 13:41:54 2025 -0800" }, "message": "all: upgrade go directive to at least 1.23.0 [generated]\n\nBy now Go 1.24.0 has been released, and Go 1.22 is no longer supported\nper the Go Release Policy (https://go.dev/doc/devel/release#policy).\n\nFor golang/go#69095.\n\n[git-generate]\n(cd . \u0026\u0026 go get go@1.23.0 \u0026\u0026 go mod tidy \u0026\u0026 go fix ./... \u0026\u0026 go mod edit -toolchain\u003dnone)\n\nChange-Id: I8369e7520e7c4881978b7dabc9e03f8cd86a3939\nReviewed-on: https://go-review.googlesource.com/c/review/+/649397\nAuto-Submit: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "53e0267ad4a55f61f94f167e38ccfa2aa7970662", "tree": "43018e8b669d85c53d763d41c93b6bb55891fe7d", "parents": [ "4a04a74d1b260f6a0799b75932102636b97edea4" ], "author": { "name": "Ian Lance Taylor", "email": "iant@golang.org", "time": "Thu Feb 06 10:48:39 2025 -0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Feb 06 13:31:03 2025 -0800" }, "message": "git-codereview: pending: add -g option\n\nThis is a convenient format for listing changes awaiting review,\nfor pasting into an e-mail or chat.\n\nChange-Id: Ib31bf0307d34aaca3e4de4baf9be4c3b3ac60be7\nReviewed-on: https://go-review.googlesource.com/c/review/+/647096\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nCommit-Queue: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nAuto-Submit: Ian Lance Taylor \u003ciant@google.com\u003e\n" }, { "commit": "4a04a74d1b260f6a0799b75932102636b97edea4", "tree": "34672932d6e69e71205280d80f9c2995ebbb8084", "parents": [ "305c213ba3528624e2ae3c6c1faa78cef1ea9aaa" ], "author": { "name": "Ian Lance Taylor", "email": "iant@golang.org", "time": "Thu Oct 31 15:39:22 2024 -0700" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Sat Nov 02 04:17:07 2024 +0000" }, "message": "README: don\u0027t mention GOPATH\n\nAdd a pointer to the git repo.\n\nFor golang/go#62645\n\nChange-Id: Ie28be88c7ed4ff3f0f758a7cf8f1c5bf64e5a1f3\nReviewed-on: https://go-review.googlesource.com/c/review/+/624215\nCommit-Queue: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nAuto-Submit: Ian Lance Taylor \u003ciant@google.com\u003e\n" }, { "commit": "305c213ba3528624e2ae3c6c1faa78cef1ea9aaa", "tree": "acefe3ddf3ac86dad6ac5c17125fe650ac15a001", "parents": [ "c91ae924997076a8e6e6f16d1d9fb75f812e0cdd" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Jul 16 11:35:23 2024 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Jul 16 16:10:26 2024 +0000" }, "message": "LICENSE: update per Google Legal\n\nVery minor tweaks:\n - Remove (c) pseudosymbol.\n - Remove \"All Rights Reserved.\"\n - Change \"Google Inc.\" (no longer exists) to \"Google LLC\".\n\n[git-generate]\necho \u0027\n,s/\\(c\\) //\n,s/ All rights reserved.//\n,s/Google Inc./Google LLC/\nw\nq\n\u0027 | sam -d LICENSE\n\nChange-Id: I9ac1297e97f67367d42bbe91bc22d8feaa96fa2e\nReviewed-on: https://go-review.googlesource.com/c/review/+/598526\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nAuto-Submit: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\n" }, { "commit": "c91ae924997076a8e6e6f16d1d9fb75f812e0cdd", "tree": "4c0a5cea9e3bf67b3fa820a95d6909e6e5450de7", "parents": [ "38b40c0e2b9e3a62d9a99d62fa70595a5f68e6c9" ], "author": { "name": "Cherry Mui", "email": "cherryyz@google.com", "time": "Tue May 11 17:07:33 2021 -0400" }, "committer": { "name": "Cherry Mui", "email": "cherryyz@google.com", "time": "Wed Apr 03 20:29:03 2024 +0000" }, "message": "git-codereview: use --no-ff for sync-branch\n\nWhen working with dev branches, it is possible that a branch\nneeded to be sync\u0027d can be fast-forworded. For example, there is\nno new commit since the last sync. Or this could happen with\nmulti-release-cycle branches, where we reverse-sync\u0027d to master\nfor one release cycle, later try to sync master to branch for the\nnext cycle. Fast-forwording is generally not what we want (and it\nconfuses the git-codereview tool when trying to craft the CL\ndescription). Pass --no-ff to ensure we create a merge commit.\n\nChange-Id: Ic204882d0304ec538c2e219d34e370ba98db9374\nReviewed-on: https://go-review.googlesource.com/c/review/+/319069\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "38b40c0e2b9e3a62d9a99d62fa70595a5f68e6c9", "tree": "bb7a19b85a177d261ff47a4fc2be127fac53389c", "parents": [ "0e3f2836ef3e230ced34f5550aa937610e076531" ], "author": { "name": "Joshua Sing", "email": "joshua@hypera.dev", "time": "Sun Nov 19 02:19:34 2023 +1100" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Feb 29 18:41:27 2024 +0000" }, "message": "git-codereview: improve haveGerritInternal\n\nUse url.Parse and check URL components rather than performing imprecise\nstring matching. This addresses a bug where git-codereview does not work\nwhen the Git origin ends with a forward slash.\n\nNote that the check for \u0027github.com\u0027 has been removed since the test for\n\u0027.googlesource.com\u0027 already excludes it.\n\nChange-Id: I083bccdbacf2152cbfddd2407fb20afa47c8e91e\nReviewed-on: https://go-review.googlesource.com/c/review/+/543495\nReviewed-by: Carlos Amedee \u003ccarlos@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nRun-TryBot: Joel Sing \u003cjoel@sing.id.au\u003e\n" }, { "commit": "0e3f2836ef3e230ced34f5550aa937610e076531", "tree": "a1341a161f6592d1e3591394d6ee99037c4ac646", "parents": [ "8be3abfe097ddf04b28eec2783249d29b3a48dae" ], "author": { "name": "Joshua Sing", "email": "joshua@hypera.dev", "time": "Sun Nov 19 14:29:24 2023 +1100" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Jan 25 17:04:12 2024 +0000" }, "message": "git-codereview: remove usage of io/ioutil\n\nio/ioutil is now deprecated. Use non-deprecated equivalents.\n\nChange-Id: Iad1cc9c14dbdad3a6f9ada25072bc194bace4081\nReviewed-on: https://go-review.googlesource.com/c/review/+/543615\nReviewed-by: qiulaidongfeng \u003c2645477756@qq.com\u003e\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nReviewed-by: Cherry Mui \u003ccherryyz@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "8be3abfe097ddf04b28eec2783249d29b3a48dae", "tree": "7839249866fdd7da93221eaf0ef9ee2b82e44ba4", "parents": [ "406355a4df8af4b140e43c56c0c4c9869471edca" ], "author": { "name": "siddharth ravikumar", "email": "s@ricketyspace.net", "time": "Mon Sep 11 22:34:15 2023 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Oct 18 12:53:42 2023 +0000" }, "message": "git-codereview: make hooks command report conflicting hooks\n\nDisplay warning message when a hook is already installed and is\ndifferent from the one installed by git-codereview.\n\nImproves upon CL 184417.\n\nFixes golang/go#16777\n\nChange-Id: I7579a3e86572e8b74f92317973e7cc7094b3942d\nReviewed-on: https://go-review.googlesource.com/c/review/+/377034\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Than McIntosh \u003cthanm@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n" }, { "commit": "406355a4df8af4b140e43c56c0c4c9869471edca", "tree": "08b6cd10b112b41ef5c6c4ca9ee43618263c9809", "parents": [ "f951e778cd57702302a4e97251e4fc67a98fd3ec" ], "author": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Tue Oct 10 19:19:10 2023 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Oct 11 14:05:16 2023 +0000" }, "message": "all: update go directive to 1.18\n\nDone with:\n\ngo get go@1.18\ngo mod tidy\ngo fix ./...\n\nUsing go1.21.3.\n\nWhile here, use testing.T.Helper directly and delete go19_test.go.\n\nFor golang/go#60268.\n\nChange-Id: I924bb6d107180a04d1f879003b169c7f792d8dd4\nReviewed-on: https://go-review.googlesource.com/c/review/+/534198\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "f951e778cd57702302a4e97251e4fc67a98fd3ec", "tree": "100eed87b0381c3ace8d395c2377d2760cb93a8c", "parents": [ "dbef367af75863876323ec31693d7cd0d65d5f9e" ], "author": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Sun Oct 01 14:25:52 2023 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Oct 02 13:50:15 2023 +0000" }, "message": "git-codereview: use strings.Cut\n\nBasic cut functionality is available in the standard library as of\nGo 1.18, so today\u0027s supported Go versions (1.21 \u0026 1.20) can use it.\n\nAlso simplify some slice and map code while here.\n\nChange-Id: Ie887fc2dad542cd9a830974cf9c8373baa81ad8b\nReviewed-on: https://go-review.googlesource.com/c/review/+/531955\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Carlos Amedee \u003ccarlos@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "dbef367af75863876323ec31693d7cd0d65d5f9e", "tree": "c6a1b96d8d13318a4810f84d0fb39ebf7122552c", "parents": [ "a7f03fb75ac9ca173ff7d2d453bc09f3fb975220" ], "author": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Fri Aug 25 15:31:43 2023 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Aug 28 20:59:30 2023 +0000" }, "message": "git-codereview: change default -trybot flag to use LUCI\n\nFor when it\u0027s time.\n\nChange-Id: Ife6df8eed0a02d9a47ffca141be083aaf3b09d28\nReviewed-on: https://go-review.googlesource.com/c/review/+/523115\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\n" }, { "commit": "a7f03fb75ac9ca173ff7d2d453bc09f3fb975220", "tree": "1d142215b9eabdb5ade76e0ab91813be1524cb89", "parents": [ "fbc0ad724bc7391431d6b4c69eec7d842a604850" ], "author": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Fri Aug 25 15:34:18 2023 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Fri Aug 25 20:23:13 2023 +0000" }, "message": "git-codereview: add GIT_CODEREVIEW_TRYBOT env var to control CI system\n\nThe mail command has a -trybot flag, useful to start TryBots on the CL\nbeing mailed. The new LUCI trybots are almost ready, and we\u0027ll soon be\nasking contributors to consider them the new default. Prepare for that\nby adding a temporary GIT_CODEREVIEW_TRYBOT environment variable which\nwill make it possible to override the CI system invoked by the -trybot\nflag.\n\nThis CL keeps the default as the old CI system (farmer.golang.org),\nand the next CL switches it to the new one (ci.chromium.org/p/golang).\n\nThe environment variable will eventually be removed once it has no use.\n\nChange-Id: Ia20bb0cad1fee387b2d94a8438e8a3be3ec87e6b\nReviewed-on: https://go-review.googlesource.com/c/review/+/523095\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nRun-TryBot: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "fbc0ad724bc7391431d6b4c69eec7d842a604850", "tree": "f818c1f53324bfad2247332047cc7de9f346b299", "parents": [ "1ade026284a47e90ec5d88ab48f869725092b4cb" ], "author": { "name": "cui fliter", "email": "imcusg@gmail.com", "time": "Tue Aug 15 10:49:30 2023 +0800" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Aug 16 01:59:36 2023 +0000" }, "message": "git-codereview: fix comment\n\nChange-Id: I265d394872a05441ccbf73388e9ff1b625435343\nReviewed-on: https://go-review.googlesource.com/c/review/+/518638\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nRun-TryBot: Ian Lance Taylor \u003ciant@google.com\u003e\nAuto-Submit: Ian Lance Taylor \u003ciant@google.com\u003e\n" }, { "commit": "1ade026284a47e90ec5d88ab48f869725092b4cb", "tree": "4a613591cb0b90984484516f060e3d3dbc659943", "parents": [ "99fd4b8dbe8c97a1cc916aec11206eb063213b43" ], "author": { "name": "Sean Liao", "email": "sean@liao.dev", "time": "Thu Jul 27 19:24:36 2023 +0100" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Jul 27 22:19:34 2023 +0000" }, "message": "git-codereview: allow _content to not warn\n\nFixes golang/go#45734\n\nChange-Id: I20ebc9fb728c5e91a3d71d3a6290ccf27ceb14cf\nReviewed-on: https://go-review.googlesource.com/c/review/+/496775\nRun-TryBot: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "99fd4b8dbe8c97a1cc916aec11206eb063213b43", "tree": "0587daa6dc11c2be955e516613447219815aa459", "parents": [ "1ee98ad07b3b077731a919d3cf37e7bfc1741fa3" ], "author": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Fri Jun 23 21:17:00 2023 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Jun 26 16:37:10 2023 +0000" }, "message": "git-codereview: fix TestReword on Windows\n\nIt wasn\u0027t caught by x/build\u0027s Windows builders because\nthey don\u0027t have git and skip these tests. But LUCI ones\ndo have git, and caught this.\n\nFor golang/go#46693.\n\nChange-Id: I50f3b69909344f4657e5c737e3b434a2538e4939\nReviewed-on: https://go-review.googlesource.com/c/review/+/505895\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nRun-TryBot: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\n" }, { "commit": "1ee98ad07b3b077731a919d3cf37e7bfc1741fa3", "tree": "bced9d1f694e7adbb3a2f1a35415777af96ba134", "parents": [ "d285cae025f6e6848090ddb748aade98677328db" ], "author": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Wed May 10 08:53:08 2023 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Thu Jun 22 19:53:14 2023 +0000" }, "message": "git-codereview: fix mail lookup for dmitshur short name\n\nCL 2111 introduced a simple algorithm for expanding short user names\nthat works locally and generally doesn\u0027t need any extra configuration\nto do the right thing. It\u0027s been serving for almost a decade.\n\nUnfortunately I\u0027m running into an edge where I see no good option but\nto add a special case. Gerrit inserts \"Reviewed-by\" footers both for\nCode-Review +2 and +1 votes without any way to distinguish between them,\nand my @google.com account unavoidably gets more hits since I use it for\nthe go.dev/s/needs-review process, whenever I leave a normal +2, and on\nmy own CLs.\n\nThe simplest fix seems to be to exclude it from short matches and let\nthe existing algorithm do the rest.\n\nChange-Id: I92da69f1cd87b4c89816547015cffbed3eaaeaf6\nReviewed-on: https://go-review.googlesource.com/c/review/+/494175\nReviewed-by: MKaslann1 \u003cmkaslann1@outlook.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nRun-TryBot: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nAuto-Submit: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "d285cae025f6e6848090ddb748aade98677328db", "tree": "9b7e0e82accdbfc64111bedd76f12a1154bfb184", "parents": [ "197006278d6bfe1d37a22f19be41ed573d66796d" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jun 01 17:06:44 2023 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Jun 02 02:03:04 2023 +0000" }, "message": "git-codereview: recognize sso://go/ and rpc://go/\n\nGoogle engineers are now required to use these access methods\ninstead of https://go.googlesource.com/, so recognize them as\naliases.\n\n(It is possible for every engineer to configure their Git clients with\ninsteadOf clauses to hide these from the codereview plugin, but\nit\u0027s far less error-prone to just handle it here.)\n\nChange-Id: Ic1c9a6b45aa61b11ff25ce21bca6e49344974b04\nReviewed-on: https://go-review.googlesource.com/c/review/+/499923\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Peter Weinberger \u003cpjw@google.com\u003e\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\n" }, { "commit": "197006278d6bfe1d37a22f19be41ed573d66796d", "tree": "919dec9b688462ef4391b5366abd05ed8a2d4b84", "parents": [ "a897dc9c03c577746ba0a4033dc61f3e5983f3e2" ], "author": { "name": "Benny Siegert", "email": "bsiegert@google.com", "time": "Thu Oct 13 20:18:34 2022 +0200" }, "committer": { "name": "Benny Siegert", "email": "bsiegert@gmail.com", "time": "Tue Nov 01 17:36:02 2022 +0000" }, "message": "git-codereview: allow trailing slash in git origin\n\nAn origin like \"https://go.googlesource.com/build/\" should also work.\nPerhaps this should use net/url instead of parsing URLs by hand.\n\nChange-Id: I5304324ae67c054b8377d500ecafe46b296d1531\nReviewed-on: https://go-review.googlesource.com/c/review/+/442875\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nRun-TryBot: Benny Siegert \u003cbsiegert@gmail.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "a897dc9c03c577746ba0a4033dc61f3e5983f3e2", "tree": "22bd4f11fd34fd2fc317cba54ed3c402e0991924", "parents": [ "0c548b8eec7a2541f601138b66789ae12dfbace1" ], "author": { "name": "Heschi Kreinick", "email": "heschi@google.com", "time": "Fri Sep 16 11:17:40 2022 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Oct 03 20:07:31 2022 +0000" }, "message": "git-codereview: add -autosubmit\n\nAdd a flag to set the Auto-Submit label.\n\nFor golang/go#48021.\n\nChange-Id: If704e8b5e9e0e2521eed78fe28af10d3c31ec3a0\nReviewed-on: https://go-review.googlesource.com/c/review/+/431375\nAuto-Submit: Heschi Kreinick \u003cheschi@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\nRun-TryBot: Heschi Kreinick \u003cheschi@google.com\u003e\n" }, { "commit": "0c548b8eec7a2541f601138b66789ae12dfbace1", "tree": "05f384e40871b04375744bc348f92b6443663f4c", "parents": [ "5579f240cbb7938362d82a9334c9f7a6a0d477b3" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Jul 22 11:10:54 2022 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Jul 22 15:52:49 2022 +0000" }, "message": "A+C: delete AUTHORS and CONTRIBUTORS\n\nIn 2009, Google\u0027s open-source lawyers asked us to create the AUTHORS\nfile to define \"The Go Authors\", and the CONTRIBUTORS file was in\nkeeping with open source best practices of the time.\n\nRe-reviewing our repos now in 2022, the open-source lawyers are\ncomfortable with source control history taking the place of the\nAUTHORS file, and most open source projects no longer maintain\nCONTRIBUTORS files.\n\nTo ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.\n\nFor golang/go#53961.\n\nChange-Id: Idf51261da9667c3f04b13976ed0686f06cbf42c0\nReviewed-on: https://go-review.googlesource.com/c/review/+/419101\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: David Chase \u003cdrchase@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "5579f240cbb7938362d82a9334c9f7a6a0d477b3", "tree": "375291757707881693c3b307b2598fc94598b0be", "parents": [ "ae62a0b8f23348d14a0270fafc2ee02ef5149a2e" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Jun 01 14:40:41 2022 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Jun 01 20:01:15 2022 +0000" }, "message": "git-codereview: print more about Gerrit API errors\n\nFor golang/go#50576.\n\nChange-Id: I3b67234098cbf9cd28bfa578c0b29744a4add2a3\nReviewed-on: https://go-review.googlesource.com/c/review/+/409914\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\nReviewed-by: Bryan Mills \u003cbcmills@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "ae62a0b8f23348d14a0270fafc2ee02ef5149a2e", "tree": "79cd842d9abe2376488ae8fed72f764ab0872769", "parents": [ "f2105c4cf825fe09ece01c9d554f6c0a5bc06a03" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Apr 12 16:16:53 2022 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Apr 14 15:34:40 2022 +0000" }, "message": "git-codereview: print about all Gerrit API errors\n\nTrying to chase down a problem with slow builders.\nIf this gets to be too chatty, we can limit it to builders.\n\nFor golang/go#50576.\n\nChange-Id: I16c7818153d2444c897b4946ce7baebbd646ab23\nReviewed-on: https://go-review.googlesource.com/c/review/+/399116\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Bryan Mills \u003cbcmills@google.com\u003e\n" }, { "commit": "f2105c4cf825fe09ece01c9d554f6c0a5bc06a03", "tree": "dccffc39e277ed70e910809d87037106111a7c88", "parents": [ "b1bd8c59b0eedfe9d0e2674f9a2e942666b5f478" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Apr 12 16:19:37 2022 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Apr 12 21:26:36 2022 +0000" }, "message": "git-codereview: remove -trust\n\nWe don\u0027t use that label anymore.\n\nChange-Id: Ic31841efaea5d9d9ae38077d8c3a3b6c548fee88\nReviewed-on: https://go-review.googlesource.com/c/review/+/399117\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nReviewed-by: Bryan Mills \u003cbcmills@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "b1bd8c59b0eedfe9d0e2674f9a2e942666b5f478", "tree": "c0c0069f2b13dee55e25e3d04fa3cf78955425d8", "parents": [ "adff2bbdb1effc869015960245d9d472a47859f8" ], "author": { "name": "cia-rana", "email": "kiwamura0314@gmail.com", "time": "Sat Apr 09 16:32:15 2022 +0900" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Apr 12 01:58:12 2022 +0000" }, "message": "git-codereview: fix how to install the command\n\nChange-Id: Iaa78b677af114d3e6ec48855aa8d5459e4f979ef\nReviewed-on: https://go-review.googlesource.com/c/review/+/399314\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\nReviewed-by: Kevin Burke \u003ckevin@burke.dev\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\nRun-TryBot: Ian Lance Taylor \u003ciant@google.com\u003e\nAuto-Submit: Ian Lance Taylor \u003ciant@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\n" }, { "commit": "adff2bbdb1effc869015960245d9d472a47859f8", "tree": "d6917408f828f382fc6f5f070e6866bbc8ad117d", "parents": [ "9dad70dcb7f1b857480364eb02b54f4c9378d9fa" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Mon Apr 11 13:12:29 2022 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Mon Apr 11 22:47:05 2022 +0000" }, "message": "all: gofmt\n\nGofmt to update doc comments to the new formatting.\n\nFor golang/go#51082.\n\nChange-Id: I257fdc6811a1156714d7c7934f6256f07a460b9d\nReviewed-on: https://go-review.googlesource.com/c/review/+/399618\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nAuto-Submit: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@google.com\u003e\n" }, { "commit": "9dad70dcb7f1b857480364eb02b54f4c9378d9fa", "tree": "f0ef30fa290a5aff164208a039b3e88d1c621de5", "parents": [ "8c1fa9c3b8ad0c79f9cefba3bdd8afde5d569f38" ], "author": { "name": "Filippo Valsorda", "email": "hi@filippo.io", "time": "Fri Oct 29 17:05:32 2021 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Apr 06 16:32:06 2022 +0000" }, "message": "git-codereview: handle branches checked out in a worktree\n\nChange-Id: I085f1d27e9d109a81bc40603b98ebf0d827dfd66\nReviewed-on: https://go-review.googlesource.com/c/review/+/359814\nTrust: Filippo Valsorda \u003cfilippo@golang.org\u003e\nRun-TryBot: Filippo Valsorda \u003cfilippo@golang.org\u003e\nAuto-Submit: Filippo Valsorda \u003cfilippo@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\n" }, { "commit": "8c1fa9c3b8ad0c79f9cefba3bdd8afde5d569f38", "tree": "39ab70a8f578fe69b5b29a7f863bb816c06d5c13", "parents": [ "de8a882f906a462d2dce15a16b07346147b00c86" ], "author": { "name": "Filippo Valsorda", "email": "filippo@golang.org", "time": "Mon Feb 08 00:10:48 2021 +0100" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Wed Apr 06 16:00:51 2022 +0000" }, "message": "git-codereview: fix sync-branch to work in worktrees\n\nChange-Id: I8a3bcad53eae3273dc498ba94d53fe2d50b58520\nReviewed-on: https://go-review.googlesource.com/c/review/+/290212\nTrust: Filippo Valsorda \u003cfilippo@golang.org\u003e\nRun-TryBot: Filippo Valsorda \u003cfilippo@golang.org\u003e\nAuto-Submit: Filippo Valsorda \u003cfilippo@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\n" }, { "commit": "de8a882f906a462d2dce15a16b07346147b00c86", "tree": "a8bda95e11dade7dfa228bc6585933c2e4b997e9", "parents": [ "543cc2605128e72dd7c49d32a4788fc1e2f47dc6" ], "author": { "name": "Filippo Valsorda", "email": "filippo@golang.org", "time": "Tue Apr 05 05:41:11 2022 -0400" }, "committer": { "name": "Gopher Robot", "email": "gobot@golang.org", "time": "Tue Apr 05 17:00:23 2022 +0000" }, "message": "all: update go.mod version\n\nSigned shifts in gofmt.go and submit.go require Go 1.13 or later.\n\nChange-Id: I32c84ddfd052717d06f1bbe1543a5d4558b60807\nReviewed-on: https://go-review.googlesource.com/c/review/+/398374\nTrust: Filippo Valsorda \u003cfilippo@golang.org\u003e\nRun-TryBot: Filippo Valsorda \u003cfilippo@golang.org\u003e\nAuto-Submit: Filippo Valsorda \u003cfilippo@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\n" }, { "commit": "543cc2605128e72dd7c49d32a4788fc1e2f47dc6", "tree": "2eead771ab06648a45277aa396a16ab6f746b9f2", "parents": [ "6c9968886cef395fe719e2a9bd89d9cb85aa66fb" ], "author": { "name": "Damien Neil", "email": "dneil@google.com", "time": "Wed Mar 11 08:27:33 2020 -0700" }, "committer": { "name": "Damien Neil", "email": "dneil@google.com", "time": "Thu Mar 31 17:36:57 2022 +0000" }, "message": "git-codereview: add mail --no-verify option\n\nThis adds a flag to set git push --no-verify, disabling pre-push hooks.\n\nChange-Id: I9ef686bd3ec742901d0138fc9028d65efde83e87\nReviewed-on: https://go-review.googlesource.com/c/review/+/222922\nTrust: Damien Neil \u003cdneil@google.com\u003e\nRun-TryBot: Damien Neil \u003cdneil@google.com\u003e\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\nTrust: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "6c9968886cef395fe719e2a9bd89d9cb85aa66fb", "tree": "56860f4330702578a899c1db96c9b228d3996ac6", "parents": [ "b04b288d5464253e76c11b8926cdb6721c25a073" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Sep 21 10:05:04 2021 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 27 19:37:11 2022 +0000" }, "message": "git-codereview: disable message about skipped cherry-picks in sync\n\nSync very frequently is done to zero out submitted CLs.\nNew git versions print\n\n\thint: use --reapply-cherry-picks to include skipped commits\n\thint: Disable this message with \"git config advice.skippedCherryPicks false\"\n\nThis message is noise more often than signal, so disable it during sync.\n\nChange-Id: Ida8867cbd614027f43bbbe6e6389a8920aae5293\nReviewed-on: https://go-review.googlesource.com/c/review/+/351209\nTrust: Russ Cox \u003crsc@golang.org\u003e\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\n" }, { "commit": "b04b288d5464253e76c11b8926cdb6721c25a073", "tree": "b28d9f7393e0543b05229d28fdb5c1bb2f4ee815", "parents": [ "b8ead204a2e00eca3f1554da0b908d1d7b7afb9f" ], "author": { "name": "siddharth", "email": "s@ricketyspace.net", "time": "Thu Jan 06 21:15:14 2022 -0500" }, "committer": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Fri Jan 07 20:37:27 2022 +0000" }, "message": "review: fix TestSyncRebase test\n\nDisable `advice.skippedCherryPicks` on the test client git repo to\nsuppress git\u0027s --reapply-cherry-picks hint when commits with same\ncontent but different commit hashes are skipped on rebase.\n\nFixes golang/go#50453\n\nChange-Id: I6d3a9cebf50f55c96d2ad096a58222c7988bcc61\nReviewed-on: https://go-review.googlesource.com/c/review/+/376039\nReviewed-by: Bryan Mills \u003cbcmills@google.com\u003e\nReviewed-by: Heschi Kreinick \u003cheschi@google.com\u003e\nTrust: Heschi Kreinick \u003cheschi@google.com\u003e\nTrust: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "b8ead204a2e00eca3f1554da0b908d1d7b7afb9f", "tree": "9cdf67d000154fb147b0883cb755bd76b4523a01", "parents": [ "4305ba78f05fd75ba1bc3be8457fcc2501da2c5e" ], "author": { "name": "Tobias Klauser", "email": "tklauser@distanz.ch", "time": "Fri Dec 03 20:11:11 2021 +0100" }, "committer": { "name": "Tobias Klauser", "email": "tobias.klauser@gmail.com", "time": "Fri Dec 03 21:50:33 2021 +0000" }, "message": "git-codereview: don\u0027t sign git tags\n\nFor users who set tag.gpgSign\u003dtrue in their git configuration,\ngit-codereview mail currently fails to create the .mailed git tag\nbecause a signed git tag always requires a message:\n\nfatal: no tag message?\n(running: git tag -f foobar.mailed cf87726ac456)\n/home/tklauser/go/bin/git-codereview: exit status 128\n\nFix this by overriding the tag.gpgSign configuration using git tag\n--no-sign. There is no point in having these tags signed as they should\nnever leave the local system.\n\nChange-Id: I8b7ddf3aa7709e6ea06e4d5add6cd581e9ec2e37\nReviewed-on: https://go-review.googlesource.com/c/review/+/369194\nTrust: Tobias Klauser \u003ctobias.klauser@gmail.com\u003e\nTrust: Bryan Mills \u003cbcmills@google.com\u003e\nRun-TryBot: Tobias Klauser \u003ctobias.klauser@gmail.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Bryan Mills \u003cbcmills@google.com\u003e\n" }, { "commit": "4305ba78f05fd75ba1bc3be8457fcc2501da2c5e", "tree": "51361cdbd4915abc7c81395d2b07770ddf3aeaec", "parents": [ "39ade5b068b47ea1606fc580f217ecd0cf940f8b" ], "author": { "name": "Bryan C. Mills", "email": "bcmills@google.com", "time": "Wed Dec 01 10:41:55 2021 -0500" }, "committer": { "name": "Bryan Mills", "email": "bcmills@google.com", "time": "Fri Dec 03 04:14:03 2021 +0000" }, "message": "git-codereview: log stderr and stdout from successful commands\n\nThe reason for the failures in golang/go#49899 is not clear.\nPerhaps the stderr output will shed some light on what is happening.\n\nFor golang/go#49899\n\nChange-Id: I37c6339c8ebd4a37e4ff5b3b813572193903cee4\nReviewed-on: https://go-review.googlesource.com/c/review/+/368174\nTrust: Bryan Mills \u003cbcmills@google.com\u003e\nRun-TryBot: Bryan Mills \u003cbcmills@google.com\u003e\nTryBot-Result: Gopher Robot \u003cgobot@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\n" }, { "commit": "39ade5b068b47ea1606fc580f217ecd0cf940f8b", "tree": "d233be519e59628192e4f9a6e5de22a5a6d13a64", "parents": [ "2e4fd9a232c3368afeca71043fd7538ed11c681c" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Feb 23 05:23:06 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Sep 21 14:06:30 2021 +0000" }, "message": "git-codereview: reword: apply commit message hook to edits\n\nIf you run \"git codereview reword\" you should get the same\n\"Fixes\" fixing and Change-Id insertion as with regular commit\nmessage editing.\n\nChange-Id: I77220d42b49f575c07a7c1ef786c3775ee75133c\nReviewed-on: https://go-review.googlesource.com/c/review/+/295310\nTrust: Russ Cox \u003crsc@golang.org\u003e\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\n" }, { "commit": "2e4fd9a232c3368afeca71043fd7538ed11c681c", "tree": "df8555462f594cdf1855e9930d23858dab800d83", "parents": [ "59af8024e2991b2377085f37062acf68ece50ced" ], "author": { "name": "Paul Jolly", "email": "paul@myitcv.io", "time": "Thu Jul 15 10:29:06 2021 +0100" }, "committer": { "name": "Paul Jolly", "email": "paul@myitcv.org.uk", "time": "Thu Jul 29 10:11:46 2021 +0000" }, "message": "git-codereview: add -s option for change\n\nSome projects (CUE, https://cuelang.org, is one such example) use the\nDeveloper Certificate of Origin (https://developercertificate.org) as an\nalternative to a CLA. For such projects, all commit messages must\ncontain the Signed-off-by trailer, with an email address that matches\nthe commit author. This requires the -s flag to be passed to git commit.\n\nThis change adds a -s flag to git-codereview\u0027s change command, which is\nthen simply passed through to git commit.\n\nChange-Id: I6aeac37a1bcdc6e260ae822d3a03117fb87f846f\nReviewed-on: https://go-review.googlesource.com/c/review/+/334750\nTrust: Paul Jolly \u003cpaul@myitcv.org.uk\u003e\nRun-TryBot: Paul Jolly \u003cpaul@myitcv.org.uk\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\n" }, { "commit": "59af8024e2991b2377085f37062acf68ece50ced", "tree": "acc614059c9e0cd88392f82263e0b527e7233ffd", "parents": [ "2465c8e799238385f42c2e82d9f37a301cb066d0" ], "author": { "name": "Katie Hockman", "email": "katie@golang.org", "time": "Fri May 14 17:12:03 2021 -0400" }, "committer": { "name": "Katie Hockman", "email": "katie@golang.org", "time": "Tue May 18 20:24:57 2021 +0000" }, "message": "git-codereview: set GIT_GOFMT_HOOK\u003doff for sync-branch\n\nWhen doing a merge, it\u0027s unlikely that someone\nwould want to run gofmt for files they didn\u0027t\nedit, so turn that off by default.\n\nChange-Id: I6c95b866740d5deda575feda256eee35dba3d9d1\nReviewed-on: https://go-review.googlesource.com/c/review/+/320269\nTrust: Katie Hockman \u003ckatie@golang.org\u003e\nRun-TryBot: Katie Hockman \u003ckatie@golang.org\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\n" }, { "commit": "2465c8e799238385f42c2e82d9f37a301cb066d0", "tree": "f52beb0e04f63ba404daa44f7577dc501ff0423c", "parents": [ "19899311a872616f0eb00d6eadccc1109d9047d3" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Feb 17 10:23:46 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Feb 23 10:45:24 2021 +0000" }, "message": "git-codereview: pending: show unresolved comment count\n\nAlso fix a potential crash parsing a commit with no parents.\n\nChange-Id: I1c289dde45230a3362f54037ea18023278b05ffd\nReviewed-on: https://go-review.googlesource.com/c/review/+/294129\nTrust: Russ Cox \u003crsc@golang.org\u003e\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\n" }, { "commit": "19899311a872616f0eb00d6eadccc1109d9047d3", "tree": "5f7935425f151b58a721ce134eb522e90e1f1d90", "parents": [ "840efbcaa4b8a3f0bd99f59d1eb822fecdd4bd74" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Feb 18 16:20:18 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Feb 18 21:25:49 2021 +0000" }, "message": "git-codereview: fix active rebase detection\n\nA sync + merge conflict + git rebase --continue can leave behind\na REBASE_HEAD even though it really should not. So don\u0027t use that\nas the signal that there\u0027s an active rebase.\n\nThe rebase-merge directory is a better signal and seems to be\ncleaned up more diligently than REBASE_HEAD.\n\nChange-Id: Ie5bc20156e19fc7ce3e32333babea784242dc770\nReviewed-on: https://go-review.googlesource.com/c/review/+/293838\nTrust: Russ Cox \u003crsc@golang.org\u003e\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Katie Hockman \u003ckatie@golang.org\u003e\n" }, { "commit": "840efbcaa4b8a3f0bd99f59d1eb822fecdd4bd74", "tree": "37fbd39e5fe85feb70906b17bf9eb46069b30d96", "parents": [ "08a7ebc305a96ca08b97b7de260c02543eeca323" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Jan 13 11:19:35 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Feb 17 14:21:55 2021 +0000" }, "message": "git-codereview: document sync-branch\n\nChange-Id: If5f9018bc1a87444df44c4d8ae853908ee283154\nReviewed-on: https://go-review.googlesource.com/c/review/+/283613\nTrust: Russ Cox \u003crsc@golang.org\u003e\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Filippo Valsorda \u003cfilippo@golang.org\u003e\n" }, { "commit": "08a7ebc305a96ca08b97b7de260c02543eeca323", "tree": "ca20560deacf99714ba148dfea0d0f766e34c5d5", "parents": [ "28abaf57728215cca0c42bf4ef3291109c9e271a" ], "author": { "name": "Filippo Valsorda", "email": "filippo@golang.org", "time": "Mon Feb 08 00:09:37 2021 +0100" }, "committer": { "name": "Filippo Valsorda", "email": "filippo@golang.org", "time": "Fri Feb 12 15:00:19 2021 +0000" }, "message": "git-codereview: fix runDirErr to actually use the passed directory\n\nChange-Id: I39f16f70e928999674b4f6f60c505ca0a51c46a9\nReviewed-on: https://go-review.googlesource.com/c/review/+/290211\nTrust: Filippo Valsorda \u003cfilippo@golang.org\u003e\nRun-TryBot: Filippo Valsorda \u003cfilippo@golang.org\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\n" }, { "commit": "28abaf57728215cca0c42bf4ef3291109c9e271a", "tree": "f14889374832ae477429c6a57aa049ee53c81dde", "parents": [ "027ac86e514dbb1000ae4ec5b282f39af4d2f7a3" ], "author": { "name": "Ian Lance Taylor", "email": "iant@golang.org", "time": "Tue Jan 26 13:52:43 2021 -0800" }, "committer": { "name": "Ian Lance Taylor", "email": "iant@golang.org", "time": "Wed Jan 27 23:04:16 2021 +0000" }, "message": "git-codereview: avoid race in loadGerritOrigin\n\nUse a mutex in loadGerritOrigin to avoid race when called in parallel\nby \"git coderevew pending\". Add a new initialized field so that the\ncode knows when auth has been initialized. Adjust tests accordingly.\nThe test is simply \"go test -race\".\n\nFixes golang/go#43670\n\nChange-Id: Ifb060fca6ed463f1d11a2959d03fca5e14e238c6\nReviewed-on: https://go-review.googlesource.com/c/review/+/287012\nTrust: Ian Lance Taylor \u003ciant@golang.org\u003e\nRun-TryBot: Ian Lance Taylor \u003ciant@golang.org\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Bryan C. Mills \u003cbcmills@google.com\u003e\n" }, { "commit": "027ac86e514dbb1000ae4ec5b282f39af4d2f7a3", "tree": "c2c6736725e96b5824afd97b2085cda327394445", "parents": [ "b8a6970a0e71c91d2cbed7d3a77142e2202f87a0" ], "author": { "name": "Than McIntosh", "email": "thanm@google.com", "time": "Thu Jan 14 11:02:42 2021 -0500" }, "committer": { "name": "Than McIntosh", "email": "thanm@google.com", "time": "Fri Jan 15 16:51:21 2021 +0000" }, "message": "git-codereview: fix buglet in \u0027reword\u0027 related to work trees\n\nThe reword command was trying to store a saved messages file in the\nsubdirectory .git in the repo root; this doesn\u0027t work well if multiple\nwork trees are in use and the user is working in a non-main work tree.\nUse \"git rev-parse --git-path .\" instead of \"git rev-parse\n--show-top-level\" to find the location for the saved messages file.\n\nFixes golang/go#43695.\n\nChange-Id: Ie0b3e810ad585fe1c18805f4070736335a2ef2b5\nReviewed-on: https://go-review.googlesource.com/c/review/+/283646\nRun-TryBot: Than McIntosh \u003cthanm@google.com\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\nTrust: Than McIntosh \u003cthanm@google.com\u003e\n" }, { "commit": "b8a6970a0e71c91d2cbed7d3a77142e2202f87a0", "tree": "c196f7ba683ef1920535bbc5bb2842266179cb61", "parents": [ "b916a6f42a60763185b530b8bd15d6aa0099e5da" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 21:14:22 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Jan 13 14:40:17 2021 +0000" }, "message": "git-codereview: add sync-branch -merge-back-to-parent\n\nDev branches come to an end.\nMaking sync-branch help that process instead of forcing\npeople to follow a playbook will help avoid mistakes.\nThe flag name was chosen to be very unlikely to be used\naccidentally, and the commit subject and message both\nare distinct to make clear to reviewers what they are being\nasked to +2.\n\nThe Merge List is also included in full and is likely to be\nquite large, yet another signal for everyone involved about\nthe magnitude and weight of the change.\n\nChange-Id: I91cdda2b85cd3811711a339f4f3290fee109022e\nReviewed-on: https://go-review.googlesource.com/c/review/+/282534\nTrust: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Matthew Dempsky \u003cmdempsky@google.com\u003e\n" }, { "commit": "b916a6f42a60763185b530b8bd15d6aa0099e5da", "tree": "5a15f56c8e482c8a781ffc2155b5c72a1111d72b", "parents": [ "fdc5e6a4e6b93c6381d20cf1dfbfaa49f420a43d" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Jan 08 11:05:45 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Jan 13 14:40:11 2021 +0000" }, "message": "git-codereview: clean up detached HEAD mode\n\nLong ago I decided to return origin/HEAD from b.OriginBranch\nin detached HEAD mode, thinking it would cause obvious failures.\nBut the joke was on me - origin/HEAD is a real thing in git,\nand HEAD tracking origin/HEAD is not the right answer on dev branches.\n\nNow that each branch\u0027s codereview.cfg typically has the branch info\nwe need, we can use that in detached HEAD mode to be able to provide\nuseful displays in commands like \"git pending\". And we can be careful\nnot to do that when we don\u0027t know the actual branch.\n\nThis commit cleans all that up.\n\nChange-Id: I0e59bcb6f9b61e0cdce7a27299b7f29fef8e7048\nReviewed-on: https://go-review.googlesource.com/c/review/+/282616\nTrust: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Matthew Dempsky \u003cmdempsky@google.com\u003e\n" }, { "commit": "fdc5e6a4e6b93c6381d20cf1dfbfaa49f420a43d", "tree": "50b026373387e0ea57d83ac46e80d27a906a13de", "parents": [ "4aa052da7f65ad6eeb77cce14ef70dac82d242cc" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 12:26:06 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Jan 13 14:40:05 2021 +0000" }, "message": "git-codereview: add reword command\n\nQuoting the new docs:\n\nThe reword command edits pending commit messages.\n\n git codereview reword [commit...]\n\nReword opens the editor on the commit message for each named commit in turn.\nWhen all the editing is finished, it applies the changes to the pending\ncommits. If no commit is listed, reword applies to the most recent pending\ncommit.\n\nReword is similar in effect to running “git codereview rebase-work” and\nchanging the script action for the named commits to “reword”, or (with no\narguments) to “git commit --amend”, but it only affects the commit messages,\nnot the state of the git staged index, nor any checked-out files. This more\ncareful implementation makes it safe to use when there are local changes or,\nfor example, when tests are running that would be broken by temporary\nchanges to the checked-out tree, as would happen during “git codereview\nrebase-work”.\n\nChange-Id: I38ac939b8530bf237c6cafb911f2b17d22eaca60\nReviewed-on: https://go-review.googlesource.com/c/review/+/279718\nTrust: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Matthew Dempsky \u003cmdempsky@google.com\u003e\n" }, { "commit": "4aa052da7f65ad6eeb77cce14ef70dac82d242cc", "tree": "774f94b2ae37b5e08a68504122663656f29e471c", "parents": [ "c4d5d8fb54f168c51827b4901b8537fca9a2abc6" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 12:26:06 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Jan 13 14:39:58 2021 +0000" }, "message": "git-codereview: new sync-branch and related fixes\n\nThis CL adds a new command, \"git codereview sync-branch\",\nwhich does the appropriate git merge for the current branch.\n\nThis CL also fixes a bug in \"git codereview branchpoint\",\nand therefore also commands like \"git codereview pending\",\nwhich was getting the branchpoint wrong for merges,\nwith the effect that a merge showed too many pending CLs.\n\nThis CL also fixes a bug in \"git codereview change\", which was\nformerly willing to run \"git checkout\" with a pending merge,\nwhich had the effect of flattening the merge mysteriously.\nNow it detects the merge and refuses to run.\n\nAll of this should make merges easier and less error-prone\nas we use dev branches more often.\n\nWith the earlier CL in this stack that allows working directly\non local branches, this is now a great way to run a merge\nupdating dev.regabi:\n\n\tgit change dev.regabi\n\tgit sync-branch\n\n(with appropriate aliases to avoid typing \"codereview\").\n\nFixes golang/go#26201.\n\nChange-Id: Ic24603123ca5135a72004309f5bb208ff149c9eb\nReviewed-on: https://go-review.googlesource.com/c/review/+/279772\nTrust: Russ Cox \u003crsc@golang.org\u003e\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Matthew Dempsky \u003cmdempsky@google.com\u003e\n" }, { "commit": "c4d5d8fb54f168c51827b4901b8537fca9a2abc6", "tree": "8fc73edbe5115d1f2917e583050aad5ae638972c", "parents": [ "5617b8658c4ff7af5665cf0fd4bc5448d4ada7b9" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 12:26:06 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 18:26:51 2021 +0000" }, "message": "git-codereview: make git change handle GitHub PRs\n\nChange-Id: Iab0417d14a29dce1a43f30f1f357d3f71dfdb51f\nReviewed-on: https://go-review.googlesource.com/c/review/+/279721\nTrust: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Matthew Dempsky \u003cmdempsky@google.com\u003e\n" }, { "commit": "5617b8658c4ff7af5665cf0fd4bc5448d4ada7b9", "tree": "4cd9e48ad8aac87b2e669024fe7605ef7d49317d", "parents": [ "3f3690dc9cf1f7c0ddca72d1c5313be4022ece58" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 12:26:06 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 18:26:46 2021 +0000" }, "message": "git-codereview: allow work on main branches\n\nThe only reason not to allow work on branches named for the\norigin branches is to preserve them for \"git change main; git change new\"\nto make a new branch tracking main. But we can still do that and\nallow commits on main - we just have to use the branchpoint\nas the root of the new branch.\n\nNow people can work on \"main\" (or \"dev.regabi\") if that suits them.\nIn particular, if you\u0027re doing merges, it\u0027s nice to be on \"dev.regabi\"\nand know for sure that\u0027s the branch you\u0027re working on.\n\nChange-Id: I8e9458793c30857a5c00e6bfd4f1cb41adbbe637\nReviewed-on: https://go-review.googlesource.com/c/review/+/279874\nTrust: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Matthew Dempsky \u003cmdempsky@google.com\u003e\nReviewed-by: Austin Clements \u003caustin@google.com\u003e\n" }, { "commit": "3f3690dc9cf1f7c0ddca72d1c5313be4022ece58", "tree": "f302f9307c7019340957396f040613f2962e6417", "parents": [ "541f6aec3b30c1bd064ea95cdaaf57f4e65bef4d" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 12:26:06 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 18:26:42 2021 +0000" }, "message": "git-codereview: add a few more tests\n\nChange-Id: I17ad065e8b4c1eb00cdd2f17af82be76bae4fc09\nReviewed-on: https://go-review.googlesource.com/c/review/+/279717\nTrust: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Matthew Dempsky \u003cmdempsky@google.com\u003e\n" }, { "commit": "541f6aec3b30c1bd064ea95cdaaf57f4e65bef4d", "tree": "660810907f7bd23d80f421446509fb685d041b59", "parents": [ "9593f86427dedbe2eda472886bd2a4f8c965abf5" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 12:26:06 2021 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Jan 07 17:26:24 2021 +0000" }, "message": "git-codereview: update tests for \"main\" branch default\n\n\"git init .\" leaves me on \"main\" now, not \"master\".\nUpdate tests to expect that, and update the \"tracking\" message too\n(otherwise the tests fail).\n\nBecause not all gits agree about the initial branch name,\nset it explicitly too in the test.\n\nFixes #42926.\n\nChange-Id: If3adb3bb53beba9efcd75cad0f081f59fba85fe7\nReviewed-on: https://go-review.googlesource.com/c/review/+/279873\nTrust: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Matthew Dempsky \u003cmdempsky@google.com\u003e\nReviewed-by: Austin Clements \u003caustin@google.com\u003e\n" }, { "commit": "9593f86427dedbe2eda472886bd2a4f8c965abf5", "tree": "24c1c30d8d3266288948f5ac0bdde40bedb857af", "parents": [ "0edcedeff807fefacf0249cdc78b5db4d956f514" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Mon Sep 14 15:11:02 2020 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Tue Dec 22 22:16:19 2020 +0000" }, "message": "git-codereview: clean up usage message, docs\n\nChange-Id: I634a9d47401c1000bcb38e9dd7e84296a3de00e6\nReviewed-on: https://go-review.googlesource.com/c/review/+/254746\nTrust: Russ Cox \u003crsc@golang.org\u003e\nTrust: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "0edcedeff807fefacf0249cdc78b5db4d956f514", "tree": "75746bc6378f2a57d0365b8789d923d82faf4af3", "parents": [ "3c482744cb56e16a5547cb048a12845d62497497" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Sep 11 11:05:28 2020 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Sep 11 20:38:40 2020 +0000" }, "message": "git-codereview: add mail -trust to set Trust+1 vote\n\nThe expectation is that approvers will change their .gitconfig\nto define mail as codereview mail -trust.\n\nFor golang/go#40699.\n\nChange-Id: I2a1040bf3f1c7248e9c361e1f2a83c17870b1df5\nReviewed-on: https://go-review.googlesource.com/c/review/+/254421\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Andrew Bonventre \u003candybons@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\n" }, { "commit": "3c482744cb56e16a5547cb048a12845d62497497", "tree": "3420fb5984ba925a5a91f6f615ab01a23ecfb570", "parents": [ "a2b90d2f6e29477343826a7b79798b588394f4aa" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Sep 11 10:20:23 2020 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Sep 11 20:38:38 2020 +0000" }, "message": "git-codereview: change upstream fallback to try main before master\n\nWill help when we start using origin/main in Go repos.\n(Tested using git-codereview against github.com/google/licensecheck.)\n\nChange-Id: I564a0f6863938a3196dea3df9e8af240faba91fc\nReviewed-on: https://go-review.googlesource.com/c/review/+/254420\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Andrew Bonventre \u003candybons@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\n" }, { "commit": "a2b90d2f6e29477343826a7b79798b588394f4aa", "tree": "9b1e2d3673716948e7051839e2eba4b1e1d970a0", "parents": [ "180dd7fcad2ad38f8a3b778687cac4c1a5ca7627" ], "author": { "name": "Paul Jolly", "email": "paul@myitcv.io", "time": "Mon May 11 06:16:42 2020 +0100" }, "committer": { "name": "Paul Jolly", "email": "paul@myitcv.org.uk", "time": "Fri May 15 04:49:42 2020 +0000" }, "message": "git-codereview: add -wip flag to mail command\n\nAdd a -wip flag to the mail command to set the status of a change to\nwork-in-progress. Per:\n\nhttps://gerrit-review.googlesource.com/Documentation/intro-user.html#wip\n\nFixes golang/go#20991\n\nChange-Id: I227beccb55570949e9b0f487d5394855611a118a\nReviewed-on: https://go-review.googlesource.com/c/review/+/233237\nReviewed-by: Daniel Martí \u003cmvdan@mvdan.cc\u003e\nReviewed-by: Andrew Bonventre \u003candybons@golang.org\u003e\n" }, { "commit": "180dd7fcad2ad38f8a3b778687cac4c1a5ca7627", "tree": "89926eab4cb1ed9576703e8b1a1789138745c933", "parents": [ "f51a73253c4da005cfdf18a036e11185c04c8ce3" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Mar 11 09:43:46 2020 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Wed Mar 11 14:50:59 2020 +0000" }, "message": "git-codereview: remove use of Mergeable\n\nMergeable has been removed from the Gerrit API -\nit was too expensive to maintain, had racy semantics,\nand was too little used.\n\nAs of right now, git submit fails because it doesn\u0027t see\n\"mergeable\":true in the JSON.\n\nRemove the use of it in git-codereview.\n\nChange-Id: I12c821b9dbc44183a689d510dd20104eab5a0043\nReviewed-on: https://go-review.googlesource.com/c/review/+/222937\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Andrew Bonventre \u003candybons@golang.org\u003e\n" }, { "commit": "f51a73253c4da005cfdf18a036e11185c04c8ce3", "tree": "11f8d4f696b1975c133791910ebd60b052914668", "parents": [ "f64da474f58aa878a967c0f87c39747f42fe6b63" ], "author": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Tue Dec 05 23:40:41 2017 -0500" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Wed Jan 15 19:54:23 2020 +0000" }, "message": "git-codereview: add mail -nokeycheck option\n\nThis adds a flag to set git push -o nokeycheck.\n\nThis is an alternative to CL 163158 (to always do it) and CL 81937\n(which adds a broader flag without much in the way of guidance of how\nto use it)\n\nChange-Id: I42b1c047ac92aeaea98c0838738e265ffdca0108\nReviewed-on: https://go-review.googlesource.com/c/review/+/214918\nRun-TryBot: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Russ Cox \u003crsc@golang.org\u003e\n" }, { "commit": "f64da474f58aa878a967c0f87c39747f42fe6b63", "tree": "3651191f3158470b284a11085f74b68d2bf66cd5", "parents": [ "be34946817dcf706c2f9448ebd50102472c552f6" ], "author": { "name": "Bryan C. Mills", "email": "bcmills@google.com", "time": "Mon Dec 16 10:05:06 2019 -0500" }, "committer": { "name": "Bryan C. Mills", "email": "bcmills@google.com", "time": "Mon Dec 16 19:06:16 2019 +0000" }, "message": "git-codereview: write hooks with execute permission in tests\n\nThe \u0027write\u0027 helper function previously assumed file permission 0666.\nWe don\u0027t actually need these files to be world-writable, but we do\nneed specific ones — scripts executed as Git commit hooks — to be\nexecutable, at least on certain platforms.\n\nAlso use t.Helper() to produce more useful log lines for failures.\n(That was added in order to diagnose TryBot failures.)\n\nFixes golang/go#32836\n\nChange-Id: I2d670563f42778ef8cf645445420756599c37ac6\nReviewed-on: https://go-review.googlesource.com/c/review/+/211477\nRun-TryBot: Bryan C. Mills \u003cbcmills@google.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Alexander Rakoczy \u003calex@golang.org\u003e\n" }, { "commit": "be34946817dcf706c2f9448ebd50102472c552f6", "tree": "e1ff91a0d1832a4547dec273884578a32771a6ce", "parents": [ "44454f6a837226d68c264174b72b85084f01c1a7" ], "author": { "name": "Daniel Lublin", "email": "daniel@lublin.se", "time": "Tue Nov 12 08:54:55 2019 +0100" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Tue Nov 12 15:45:06 2019 +0000" }, "message": "git-codereview: pick up URL-specific cookieFile config\n\nExample config:\n\n [http \"https://go.googlesource.com\"]\n cookiefile \u003d ~/.gitcookies-googlesource\n\nThe --get-urlmatch option falls back to non-URL-specific config.\n\nFixes golang/go#35496\n\nChange-Id: I2410ff5b55e2bf9214fcc2cad16095facec78434\nReviewed-on: https://go-review.googlesource.com/c/review/+/206697\nReviewed-by: Josh Bleecher Snyder \u003cjosharian@gmail.com\u003e\nRun-TryBot: Josh Bleecher Snyder \u003cjosharian@gmail.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\n" }, { "commit": "44454f6a837226d68c264174b72b85084f01c1a7", "tree": "d3bd91a94feebb0092729a046d43e71f661380b9", "parents": [ "85688492bf1b598c999c025b9d626ae298968a43" ], "author": { "name": "Eric Lagergren", "email": "eric@ericlagergren.com", "time": "Wed Aug 28 16:29:14 2019 -0700" }, "committer": { "name": "Josh Bleecher Snyder", "email": "josharian@gmail.com", "time": "Sat Nov 09 00:12:09 2019 +0000" }, "message": "git-codereview: override existing locale with LC_ALL\u003dC\n\nThe git-codereview tool shells out to git, then parses the output.\nHowever, because git respects a user\u0027s locale settings its output might\nnot be in English, confusing git-codereview.\n\nExplicitly set the LC_ALL environment variable to the \"C\" locale, which\nis a version of US English that should be on all machines.\n\nFixes golang/go#33895\n\nChange-Id: Id06a81046dba58131fc1de602dd9add687846da1\nReviewed-on: https://go-review.googlesource.com/c/review/+/192237\nReviewed-by: Josh Bleecher Snyder \u003cjosharian@gmail.com\u003e\nReviewed-by: Daniel Martí \u003cmvdan@mvdan.cc\u003e\nRun-TryBot: Josh Bleecher Snyder \u003cjosharian@gmail.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\n" }, { "commit": "85688492bf1b598c999c025b9d626ae298968a43", "tree": "cb15d2bfb60be1ee05c094ded63f18f6d2a2657d", "parents": [ "11e366f73b1246ae71e6fcf989a0c7ce06bbe6ed" ], "author": { "name": "Anderson Queiroz", "email": "contato@andersonq.eti.br", "time": "Tue Sep 17 09:35:23 2019 +0200" }, "committer": { "name": "Daniel Martí", "email": "mvdan@mvdan.cc", "time": "Wed Sep 25 10:39:08 2019 +0000" }, "message": "git-codereview: do not install hooks for help and invalid commands\n\nFixes golang/go#34320\n\nChange-Id: I53348a027d1a33d1614d2bad32c75eaca52fac8a\nReviewed-on: https://go-review.googlesource.com/c/review/+/195897\nRun-TryBot: Daniel Martí \u003cmvdan@mvdan.cc\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Daniel Martí \u003cmvdan@mvdan.cc\u003e\n" }, { "commit": "11e366f73b1246ae71e6fcf989a0c7ce06bbe6ed", "tree": "93053c7f96c6ba1642524d93af66d1af3178bb12", "parents": [ "8102926ea734b775eb275a7850bad0a56b6bcf34" ], "author": { "name": "Bryan C. Mills", "email": "bcmills@google.com", "time": "Fri Aug 30 08:54:16 2019 -0400" }, "committer": { "name": "Bryan C. Mills", "email": "bcmills@google.com", "time": "Fri Aug 30 13:57:01 2019 +0000" }, "message": "go.mod: add go version directive\n\n(I mostly just wanted to make a trivial change to this repo to clear\nout the failure cells for misconfigured builders on the landing page\nof https://build.golang.org.)\n\nUpdates golang/go#32836\n\nChange-Id: Ibcea7e75912ca377fd78cef37d8beb29ab8b83d3\nReviewed-on: https://go-review.googlesource.com/c/review/+/192557\nRun-TryBot: Bryan C. Mills \u003cbcmills@google.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\n" }, { "commit": "8102926ea734b775eb275a7850bad0a56b6bcf34", "tree": "70b5d92b7beedfb2ea5c124a2eff1e45173ee7db", "parents": [ "83908358f3a5c0332c3043570ce65ab14ff3d087" ], "author": { "name": "Yury Smolsky", "email": "yury@smolsky.by", "time": "Wed Nov 07 17:57:29 2018 +0200" }, "committer": { "name": "Yury Smolsky", "email": "yury@smolsky.by", "time": "Wed May 08 20:43:55 2019 +0000" }, "message": "git-codereview: add a hint about mailing the whole chain of changes\n\n\"mail HEAD\" will mail every commit between HEAD and branching point.\n\nFixes golang/go#16034\n\nChange-Id: If95aece584f2a324f866c64770f7361ddb3e7636\nReviewed-on: https://go-review.googlesource.com/c/review/+/148137\nReviewed-by: Josh Bleecher Snyder \u003cjosharian@gmail.com\u003e\n" }, { "commit": "83908358f3a5c0332c3043570ce65ab14ff3d087", "tree": "7fc5bf4489e39cfffbd62a88e6903006831cff07", "parents": [ "7744f6d7ac193720bb483dc2a2c266504b33d1a9" ], "author": { "name": "Rebecca Stambler", "email": "rstambler@golang.org", "time": "Mon Apr 22 17:52:48 2019 -0400" }, "committer": { "name": "Rebecca Stambler", "email": "rstambler@golang.org", "time": "Mon Apr 22 22:03:18 2019 +0000" }, "message": "git-codereview: do not require gofmt for testdata files\n\nWe use Go files as testdata for gopls, specifically as test cases for\nformatting and imports.\n\nChange-Id: Ie4ed6097960eb0eb3d5c1767b8b76bed147c81e0\nReviewed-on: https://go-review.googlesource.com/c/review/+/173339\nRun-TryBot: Rebecca Stambler \u003crstambler@golang.org\u003e\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\n" }, { "commit": "7744f6d7ac193720bb483dc2a2c266504b33d1a9", "tree": "ee8009a5598eaa5798124ef09af58f12fad81ab4", "parents": [ "05c26900aa9101b5ab40490ad329fab7dfa56cb6" ], "author": { "name": "Andrew Gerrand", "email": "adg@golang.org", "time": "Mon Mar 25 11:35:57 2019 +1100" }, "committer": { "name": "Andrew Gerrand", "email": "adg@golang.org", "time": "Mon Mar 25 02:02:52 2019 +0000" }, "message": "git-codereview: make commit-msg hook play nicely with other systems\n\nGerrit requires \u0027Change-Id:\u0027 lines to be included in each commit\nmessage, but they are not the only kind of \u0027metadata line\u0027 that might\nappear in a commit message. Metadata lines observed by other systems\ninclude \u0027Bug:\u0027 and \u0027Signed-off-by:\u0027. This change ensures that the\ncommit-msg hook adds its \u0027Change-Id:\u0027 line to the set of metadata lines,\nseparated only by a single linefeed, rather than creating a new set by\ninserting two line feeds.\n\nChange-Id: Ia3bdce6f52f663685eea1e648874ef81ddb2bd91\nReviewed-on: https://go-review.googlesource.com/c/review/+/169097\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n" }, { "commit": "05c26900aa9101b5ab40490ad329fab7dfa56cb6", "tree": "386808b79617b8d95c0bc0da1fb4883f3f0b6309", "parents": [ "266ee1edf5c3fbea8205c8885c62ffdf1bd37dc1" ], "author": { "name": "Michael Matloob", "email": "matloob@golang.org", "time": "Fri Feb 15 17:32:45 2019 -0500" }, "committer": { "name": "Michael Matloob", "email": "matloob@golang.org", "time": "Wed Mar 13 15:21:26 2019 +0000" }, "message": "all: add a go.mod file\n\nThis change adds a go.mod file to this repo, following the\nrequirements stated in bcmills\u0027s comment here:\nhttps://golang.org/issue/28136#issuecomment-462971974. It\u0027s\nimportant to note that we will not be\nadding versions to the repo for now.\n\nThere is no go.sum file because this repo has no dependencies.\n\nThe change was generated by running \"go mod init\" and \"go mod tidy\" using Go\n1.11.5 in the top-level directory of the repository.\n\nUpdates golang/go#28136\n\nChange-Id: Ie24d8bb73104e8299d3d22cf6c72a295036804f7\nReviewed-on: https://go-review.googlesource.com/c/review/+/162916\nRun-TryBot: Michael Matloob \u003cmatloob@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n" }, { "commit": "266ee1edf5c3fbea8205c8885c62ffdf1bd37dc1", "tree": "c38ffd4a2bdb45badffbc6b10f92caa8de24c869", "parents": [ "80efb4d00862d577c5fc7837709252980c21f4c7" ], "author": { "name": "Daniel Theophanes", "email": "kardianos@gmail.com", "time": "Mon Jan 21 17:02:15 2019 -0800" }, "committer": { "name": "Daniel Theophanes", "email": "kardianos@gmail.com", "time": "Tue Jan 22 20:53:39 2019 +0000" }, "message": "git-codereview: do not check vendor folder with gofmt\n\nThe go command already skips the vendor folder when running\ngo fmt. The \"go mod vendor\" command updates all vendor packages\nat once, so this becomes more of an issue.\n\nChange-Id: I0b2d51d2f1f01998e9ca7a244af491bd18150e8a\nReviewed-on: https://go-review.googlesource.com/c/158839\nRun-TryBot: Daniel Theophanes \u003ckardianos@gmail.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Josh Bleecher Snyder \u003cjosharian@gmail.com\u003e\n" }, { "commit": "80efb4d00862d577c5fc7837709252980c21f4c7", "tree": "0d5f48f2023375d7bf9c3d60ada7f47369284ec8", "parents": [ "22b85151af96692018cffaacf6156c88d2b0c933" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Nov 29 11:42:07 2018 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Nov 29 16:44:46 2018 +0000" }, "message": "git-codereview: recognize rpc:// and sso:// as Gerrit origins\n\nChange-Id: I43e14ef54a5c9936f3c80fa87e9b9f0ed468b05a\nReviewed-on: https://go-review.googlesource.com/c/151737\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Bryan C. Mills \u003cbcmills@google.com\u003e\n" }, { "commit": "22b85151af96692018cffaacf6156c88d2b0c933", "tree": "e665a93fb59bfa4ec5985a82a9d6b39cbf4c33f0", "parents": [ "5745d819bd5fea5cbfb6ef4886a39b7f814c14db" ], "author": { "name": "Jean de Klerk", "email": "deklerk@google.com", "time": "Tue Apr 17 20:53:24 2018 -0700" }, "committer": { "name": "Yury Smolsky", "email": "yury@smolsky.by", "time": "Thu Nov 08 09:10:10 2018 +0000" }, "message": "git-codereview: add -m option\n\nThe -m option allows a user to specify an inline commit\nmessage. This is useful for a few reasons; primary among\nthem are the ability to easily automate a `git change`\nflow (e.g. in a CI/CD workflow) and the ease of creating\none-liner commits (e.g. \"regen protos\").\n\nFixes golang/go#24912\n\nChange-Id: Ie06886c74552ec615623c2faac285a1896bdac06\nReviewed-on: https://go-review.googlesource.com/c/107625\nRun-TryBot: Yury Smolsky \u003cyury@smolsky.by\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Yury Smolsky \u003cyury@smolsky.by\u003e\nReviewed-by: Daniel Martí \u003cmvdan@mvdan.cc\u003e\nReviewed-by: Josh Bleecher Snyder \u003cjosharian@gmail.com\u003e\n" }, { "commit": "5745d819bd5fea5cbfb6ef4886a39b7f814c14db", "tree": "f6e95ea67b8ee2771143b5954bbe46f3cfdc49d4", "parents": [ "5934012ba8014dec70c822aae374611bca0d7107" ], "author": { "name": "Johan Brandhorst", "email": "johan.brandhorst@gmail.com", "time": "Sun Oct 14 14:21:01 2018 +0100" }, "committer": { "name": "Rob Pike", "email": "r@golang.org", "time": "Sun Oct 14 23:21:25 2018 +0000" }, "message": "README.md: correct installation instructions\n\nFixes golang/go#28196\n\nChange-Id: I5fa57b039798c172a0b2610d8278077aca15512e\nReviewed-on: https://go-review.googlesource.com/c/141802\nReviewed-by: Alberto Donizetti \u003calb.donizetti@gmail.com\u003e\nReviewed-by: Rob Pike \u003cr@golang.org\u003e\n" }, { "commit": "5934012ba8014dec70c822aae374611bca0d7107", "tree": "bebc45e524fffc25bef23b0fbc971fa2dc75e02c", "parents": [ "876f02c62271942a935a8a5ac3ee3534945db491" ], "author": { "name": "Jean de Klerk", "email": "deklerk@google.com", "time": "Thu Aug 23 08:58:22 2018 -0700" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Thu Aug 23 16:34:29 2018 +0000" }, "message": "git-codereview: remove unused cruft\n\nChange-Id: If9b3494162311743d9ea84dc9dc26163d6563c9c\nReviewed-on: https://go-review.googlesource.com/131055\nRun-TryBot: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n" }, { "commit": "876f02c62271942a935a8a5ac3ee3534945db491", "tree": "f651d840e6d2360060ae6cd6dff8de93de86f915", "parents": [ "03b299b5f05180b4bd12d1de83501746dde90cc0" ], "author": { "name": "Issac Trotts", "email": "issac.trotts@gmail.com", "time": "Mon Aug 06 20:02:44 2018 +0000" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Tue Aug 07 00:44:42 2018 +0000" }, "message": "Fix erroneous error message saying \"git sync\"\n\nIt\u0027s `git codereview sync`.\n\nChange-Id: Ia55db061d0cf35cb56c6faba7bb1569e621f9b57\nGitHub-Last-Rev: 539f4d0750845686c1b0d3720f598f489dc3530f\nGitHub-Pull-Request: golang/review#11\nReviewed-on: https://go-review.googlesource.com/128075\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n" }, { "commit": "03b299b5f05180b4bd12d1de83501746dde90cc0", "tree": "10d78b847fa28e372ef200e38d84fc12b9090a2f", "parents": [ "3faf27076323fb8383c9b24e875f37a630b2f213" ], "author": { "name": "Jesús Espino", "email": "jespinog@gmail.com", "time": "Sun Jul 01 00:02:42 2018 +0200" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Mon Jul 02 20:29:14 2018 +0000" }, "message": "git-codereview: add -hashtag flag to the mail command\n\nIt is now possible to mail a CL with any number of hashtags.\n\nFixes golang/go#26149\n\nChange-Id: I231826f95ec357bd448de12a9a5aa30e581c3bb3\nReviewed-on: https://go-review.googlesource.com/121798\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n" }, { "commit": "3faf27076323fb8383c9b24e875f37a630b2f213", "tree": "daf3e9224d261b7ce276abaac0d3ef3f5f7c5393", "parents": [ "abfd23779f7118d331eb23f79506debc5f95b511" ], "author": { "name": "Mark Fischer", "email": "meirfischer@gmail.com", "time": "Sat Jun 16 17:50:03 2018 -0400" }, "committer": { "name": "Alex Brainman", "email": "alex.brainman@gmail.com", "time": "Sun Jun 17 03:00:24 2018 +0000" }, "message": "git-codereview: highlight branchpoint command\n\nPut text between title and command.\n\nFixes: golang/go#19077\n\nChange-Id: I6fe1cc3081d6aa939cd46de11fa208b4a0d6b26e\nReviewed-on: https://go-review.googlesource.com/119339\nReviewed-by: Alex Brainman \u003calex.brainman@gmail.com\u003e\n" }, { "commit": "abfd23779f7118d331eb23f79506debc5f95b511", "tree": "4edea89bc67ecab466c73841d76ca2a5d5f1b04c", "parents": [ "0d7a66991c6e16602c02f2deda6f7b0908be4b7a" ], "author": { "name": "Dmitri Shuralyov", "email": "dmitri@shuralyov.com", "time": "Sun Jun 03 14:03:53 2018 -0400" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Tue Jun 12 19:14:31 2018 +0000" }, "message": "git-codereview: use --path option of git config to expand ~\n\nThis change largely reverts CL 115576, and applies a simpler version.\nIt uses the --path option of git config to achieve equivalent behavior.\n\nThe --path option is available as far back as git 1.7.0, according to\nhttps://git-scm.com/docs/git-config/1.7.0, making it safe to rely on:\n\n\tThe type specifier can be [...] --path, which does some path expansion\n\t(see --path below). If no type specifier is passed, no checks or\n\ttransformations are performed on the value.\n\n\t--path\n\t git-config will expand leading ~ to the value of $HOME, and ~user\n\t to the home directory for the specified user.\n\nChange-Id: I74bb543ab488d24fe4cf66da0c6dbc087dc368a6\nReviewed-on: https://go-review.googlesource.com/116016\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n" }, { "commit": "0d7a66991c6e16602c02f2deda6f7b0908be4b7a", "tree": "17e2e04669d87d06635dae8df7459b8cc7adf72f", "parents": [ "d4998e72643e8f0b9edc1c6e63c8ba6fb2a2a949" ], "author": { "name": "Michael Matloob", "email": "matloob@golang.org", "time": "Tue Jun 05 17:08:39 2018 -0400" }, "committer": { "name": "Michael Matloob", "email": "matloob@golang.org", "time": "Tue Jun 05 21:14:28 2018 +0000" }, "message": "git-codereview: check for https:// origin only for googlesource urls\n\nChange-Id: Idc3ce48cb706959738c6045c3e58904399ca24f3\nReviewed-on: https://go-review.googlesource.com/116361\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n" }, { "commit": "d4998e72643e8f0b9edc1c6e63c8ba6fb2a2a949", "tree": "a8f3db441788c7b1254122d0c046e39c1027908e", "parents": [ "8545223bc1b05b842f3f3a11e66cd902bf046efe" ], "author": { "name": "Filippo Valsorda", "email": "filippo@golang.org", "time": "Thu May 31 16:21:45 2018 +0000" }, "committer": { "name": "Filippo Valsorda", "email": "filippo@golang.org", "time": "Fri Jun 01 23:22:47 2018 +0000" }, "message": "git-codereview: support ~ in http.cookiefile\n\nhttp.cookiefile is a pathname value, which means a leading tilde is\nautomatically expanded by git-config.\n\nhttps://git-scm.com/docs/git-config#git-config-httpcookieFile\nhttps://git-scm.com/docs/git-config#git-config-pathname\n\nChange-Id: Ia208b8a8a7dd5e07de58481b9010051569d0d8c8\nReviewed-on: https://go-review.googlesource.com/115576\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n" }, { "commit": "8545223bc1b05b842f3f3a11e66cd902bf046efe", "tree": "ad992cb6ae3172eaccf3cb36eb83eec298fac0cb", "parents": [ "febe82b3542e335479ef0e8a401a0e95f070fa41" ], "author": { "name": "Marvin Stenger", "email": "marvin.stenger94@gmail.com", "time": "Wed Apr 04 12:34:26 2018 +0200" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Wed Apr 04 16:07:47 2018 +0000" }, "message": "git-codereview: pull punctuation marks out of quotation marks\n\nCommand-line commands listed in the documentation are put in quotation\nmarks. In some places punctuation marks were also placed between the\nquotation marks, which could suggest that they are part of the command.\nSo we pull those punctuation marks out.\n\nChange-Id: I7057747a0f045394976f04f8be387e18805c22e1\nReviewed-on: https://go-review.googlesource.com/104657\nReviewed-by: Daniel Martí \u003cmvdan@mvdan.cc\u003e\nReviewed-by: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\n" }, { "commit": "febe82b3542e335479ef0e8a401a0e95f070fa41", "tree": "b3d746400bde7ae847f6c7e8d00ca929c6ba06c5", "parents": [ "34696713d8ce9c6e709a50d8192fd973246a30e9" ], "author": { "name": "Yury Smolsky", "email": "yury@smolsky.by", "time": "Wed Mar 21 01:23:00 2018 +0200" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Fri Mar 30 21:38:54 2018 +0000" }, "message": "git-codereview: forbid mailing editor temp files\n\n\"mail\" command rejects *~, #*# and .#* filenames.\n\nAlso it should reject commit messages with non-printable characters,\nbecause these are impossible to spot in the review.\n\nFor golang/go#24139\n\nChange-Id: I3544e3c34c5ac9f55a7808264de4535bc455bd0a\nReviewed-on: https://go-review.googlesource.com/101755\nRun-TryBot: Yury Smolsky \u003cyury@smolsky.by\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Austin Clements \u003caustin@google.com\u003e\n" }, { "commit": "34696713d8ce9c6e709a50d8192fd973246a30e9", "tree": "36710c7feeb027c4b9ac5b7423a8ba426db6b700", "parents": [ "f5dbde0c1ab9393757674eb259f2de6e40f1a7b3" ], "author": { "name": "Andrew Bonventre", "email": "andybons@golang.org", "time": "Wed Mar 14 13:21:11 2018 -0400" }, "committer": { "name": "Andrew Bonventre", "email": "andybons@golang.org", "time": "Wed Mar 14 18:01:18 2018 +0000" }, "message": "CONTRIBUTING.md: remove note about not accepting Pull Requests\n\nUpdates golang/go#24185\n\nChange-Id: I74b024457ece54c6b02c3b017cb003142b75b4f8\nReviewed-on: https://go-review.googlesource.com/100690\nReviewed-by: Andrew Bonventre \u003candybons@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\n" }, { "commit": "f5dbde0c1ab9393757674eb259f2de6e40f1a7b3", "tree": "835b0383d49927ed320b5de9f7832299a980168b", "parents": [ "40351d005dee5f35259c1bca836e9dbbf842d119" ], "author": { "name": "Rob Pike", "email": "r@golang.org", "time": "Mon Jan 22 10:39:38 2018 +1100" }, "committer": { "name": "Rob Pike", "email": "r@golang.org", "time": "Mon Jan 22 04:07:14 2018 +0000" }, "message": "review/git-codereview: use more verbosity to signal verbose pulls\n\nThe -v flag in review is already used to signal more verbose output.\nWith one -v, git sync shows the git commands. After this change,\ntwo -vs (or -v\u003d2) causes git sync to pass -v to git pull as well.\n\nAlso mention that -v is a counter not a boolean in the documentation.\n\nChange-Id: I584068f05c2298be6ae2e6ae17a0b817dc6a092f\nReviewed-on: https://go-review.googlesource.com/88875\nReviewed-by: Andrew Gerrand \u003cadg@golang.org\u003e\n" }, { "commit": "40351d005dee5f35259c1bca836e9dbbf842d119", "tree": "54dbf056539d181807912a2fd8a459dfa482e537", "parents": [ "a57765c8edb665da29ee419e860686d336f76090" ], "author": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Fri Dec 15 01:12:24 2017 +0000" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Fri Dec 15 01:53:02 2017 +0000" }, "message": "git-codereview: fix vet warning to fix build on Go 1.10\n\nChange-Id: Ib4cee24d5b70f99dfbebf0aa05c85be6164ba835\nReviewed-on: https://go-review.googlesource.com/84216\nRun-TryBot: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Ian Lance Taylor \u003ciant@golang.org\u003e\n" }, { "commit": "a57765c8edb665da29ee419e860686d336f76090", "tree": "f68ac6b682b6b4e1e8f263f74c8389265f0a918f", "parents": [ "0a9d6c1f9f9938cdd0edbb0f97ba0917d52e4c0d" ], "author": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Wed Nov 29 21:01:11 2017 +0000" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Wed Nov 29 21:11:13 2017 +0000" }, "message": "git-codereview: fix Go 1.8 t.Helper fix\n\nDon\u0027t add a new stack frame.\n\nThanks to Dominik Honnef.\n\nChange-Id: I817f95fb23e80dcdff733a7b35fa72bac89958f8\nReviewed-on: https://go-review.googlesource.com/80795\nRun-TryBot: Brad Fitzpatrick \u003cbradfitz@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Dominik Honnef \u003cdominik@honnef.co\u003e\n" }, { "commit": "0a9d6c1f9f9938cdd0edbb0f97ba0917d52e4c0d", "tree": "d388f5b4a4780bf399fa5b1cdb0b5e25153b5e35", "parents": [ "0d52c016f0bb80623e0ce00bf4e92981bacf862e" ], "author": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Wed Nov 15 18:35:58 2017 +0000" }, "committer": { "name": "Brad Fitzpatrick", "email": "bradfitz@golang.org", "time": "Mon Nov 27 23:48:19 2017 +0000" }, "message": "git-codereview: fix test compilation error on Go 1.8\n\nThese tests depended on Go 1.9\u0027s t.Helper.\n\nChange-Id: Ib8196e24f8508b4b2891cd1467dd9954bc5d8de5\nReviewed-on: https://go-review.googlesource.com/77932\nReviewed-by: Dominik Honnef \u003cdominik@honnef.co\u003e\n" }, { "commit": "0d52c016f0bb80623e0ce00bf4e92981bacf862e", "tree": "d65021e2f934074a9c1fc8a49e4bfaa20d781c27", "parents": [ "69da225aa6e9f439011c7458bbbddd52b133aea9" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Nov 09 22:27:37 2017 -0500" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Thu Nov 16 01:36:40 2017 +0000" }, "message": "git-codereview: add support for DΟ NΟT MAIL\n\nAlso create a local DΟ NΟT SUBMIT check,\nalthough the Gerrit server is also taking care of that.\n\nWhile we\u0027re here, make fixup! and squash! commits\nnon-mailable as well.\n\n(In the all caps text above the big Os are really Omicrons.\nOtherwise the CL would not be mailable or submittable.)\n\nChange-Id: Id1a9806b0d395d1a0bfc50ed7d7d22c64a48a2f1\nReviewed-on: https://go-review.googlesource.com/76877\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nReviewed-by: Austin Clements \u003caustin@google.com\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\n" }, { "commit": "69da225aa6e9f439011c7458bbbddd52b133aea9", "tree": "fb3b060260b8dcba4a42e997114e5f82b43d207b", "parents": [ "0bdc7edde01a92e96255c6845b536d59706b9542" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Mon Oct 02 10:03:11 2017 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Nov 10 03:13:48 2017 +0000" }, "message": "git-codereview: overlap \u0027git fetch -q\u0027 with Gerrit queries in pending\n\nRight now \u0027git fetch -q\u0027 takes about one second because of Gerrit\nadvertising far too many refs. Overlap the fetch with all the other\nwork, to at least reduce the overall time for \u0027git pending\u0027.\n\nThe Gerrit team is aware of the refs advertisement problem and\na fix is planned for the next few months. That fix will speed things\nup even further.\n\nChange-Id: Iad57da9f1af1c6eae144fe28e5f96f79234bf3cd\nReviewed-on: https://go-review.googlesource.com/67572\nReviewed-by: Austin Clements \u003caustin@google.com\u003e\n" }, { "commit": "0bdc7edde01a92e96255c6845b536d59706b9542", "tree": "38e33d499a8dff245b9d3d7618c967260132a2fd", "parents": [ "c4baf783371a7c2b30b95ab528a38f6b12e7b6c1" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Mon Oct 02 09:42:13 2017 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Fri Nov 10 03:12:52 2017 +0000" }, "message": "git-codereview: batch GerritChange info fetches during pending\n\nThis speeds pending a bit by reducing the number of round trips\nto the Gerrit server when you have a stack of CLs.\n\nChange-Id: I456e1a8739b9b6586f4e05c1a5442f402e440a79\nReviewed-on: https://go-review.googlesource.com/67571\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Austin Clements \u003caustin@google.com\u003e\n" }, { "commit": "c4baf783371a7c2b30b95ab528a38f6b12e7b6c1", "tree": "3f94d7ee2cabb0c8dcce03970ea96daa62d3c6a0", "parents": [ "0eaa382942a3219dcdf0eb1a5e6a72854ebf7dcd" ], "author": { "name": "Kevin Burke", "email": "kev@inburke.com", "time": "Mon Jul 17 12:05:22 2017 -0700" }, "committer": { "name": "Kevin Burke", "email": "kev@inburke.com", "time": "Fri Oct 06 14:39:39 2017 +0000" }, "message": "git-codereview: specify a dummy cookie file\n\nThis test was incorrectly passing when it should be dying, because\nI have a global http.cookiefile defined that this test falls back to\nusing if a local http.cookiefile isn\u0027t configured.\n\nFix this by defining a local, invalid cookiefile, which causes\ngit/git-codereview to error out.\n\nChange-Id: Ia538d3e8af53b849d672419582c21ba8a6fdbbdd\nReviewed-on: https://go-review.googlesource.com/49293\nReviewed-by: Andrew Bonventre \u003candybons@golang.org\u003e\n" }, { "commit": "0eaa382942a3219dcdf0eb1a5e6a72854ebf7dcd", "tree": "6be5263153e9241815e567f1c035e6297c1b5587", "parents": [ "925f9bd3fb4bf9cda7fef491941894d634b3b535" ], "author": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Mon Oct 02 09:19:37 2017 -0400" }, "committer": { "name": "Russ Cox", "email": "rsc@golang.org", "time": "Mon Oct 02 23:47:59 2017 +0000" }, "message": "git-codereview: avoid Gerrit timeout for missing Change-Id during pending\n\nIf a commit is missing a Change-Id line, pending queries\n\n\thttps://go-review.googlesource.com/a/changes/go~master~?o\u003dDETAILED_LABELS\u0026o\u003dCURRENT_REVISION\u0026o\u003dMESSAGES\u0026o\u003dDETAILED_ACCOUNTS\n\n(that\u0027s go~master~CHANGEID?... with CHANGEID\u003d\"\"),\nwhich must cause Gerrit to iterate over all possible CLs\nor something like that, because it takes forever.\n\nDon\u0027t bother: if the commit we care about has no Change-Id,\nit is by definition not on the server at all.\n\nThis makes \u0027git pending\u0027 not just hang when you have a\ncommit without a Change-Id.\n\nChange-Id: I548a51b4190db723538af35ea6a14169861d6bc3\nReviewed-on: https://go-review.googlesource.com/67570\nRun-TryBot: Russ Cox \u003crsc@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Austin Clements \u003caustin@google.com\u003e\n" }, { "commit": "925f9bd3fb4bf9cda7fef491941894d634b3b535", "tree": "31085385592a78ceefff6c1ac74e9f848e8f4387", "parents": [ "d9d84288482b14b19527db3f0a0d4b4fc5a6bbd0" ], "author": { "name": "Kevin Burke", "email": "kev@inburke.com", "time": "Tue Jul 18 20:36:05 2017 -0700" }, "committer": { "name": "Kevin Burke", "email": "kev@inburke.com", "time": "Wed Sep 27 05:38:32 2017 +0000" }, "message": "README: add better description\n\nMove the README to README.md so Gerrit can render it; currently\nGerrit only renders files named exactly \"README.md\" (for example at\nhttps://go.googlesource.com/go).\n\nAdd more links to the README explaining how to file issues,\nhow to submit code changes, where to download the code to and\nhow to get it. Hopefully this should help people who go to\nhttps://go.googlesource.com/review or https://github.com/golang/review\nfigure out how to get started with development.\n\nChange-Id: Ie490adc9126b759f81af2a526e9e05270d3525e6\nReviewed-on: https://go-review.googlesource.com/49871\nReviewed-by: Kevin Burke \u003ckev@inburke.com\u003e\n" }, { "commit": "d9d84288482b14b19527db3f0a0d4b4fc5a6bbd0", "tree": "ee4ba9d3f9e9b776f35e1b72c17c6bb87d9d95f5", "parents": [ "97320b9a100175cf5220b3e1a442d706295dafcc" ], "author": { "name": "Marko Mudrinic", "email": "mudrinic.mare@gmail.com", "time": "Sun Jul 16 20:59:48 2017 +0200" }, "committer": { "name": "Kevin Burke", "email": "kev@inburke.com", "time": "Mon Jul 17 18:06:47 2017 +0000" }, "message": "git-codereview: create hooks directory if it doesn\u0027t exist\n\nFixes golang/go#21028\n\nOn some versions of Git, \"git init\" will not create \".git/hooks\ndirectory\", causing \"git change\" to fail. This fix will check if the hooks\ndirectory exists, and if not, create it.\n\nChange-Id: I6a9e688740fde8701e5d48630686039c8ebf4172\nReviewed-on: https://go-review.googlesource.com/49070\nReviewed-by: Kevin Burke \u003ckev@inburke.com\u003e\n" } ], "next": "97320b9a100175cf5220b3e1a442d706295dafcc" }