)]}'
{
  "commit": "895189e3454ab08aef270dca07a741d76eb01d50",
  "tree": "56fff4904bd179d7296742c672e60368c79fe7b6",
  "parents": [
    "55cca39997e216656d703840268b9ff8676b0672"
  ],
  "author": {
    "name": "Paul Jolly",
    "email": "paul@myitcv.io",
    "time": "Wed Apr 29 16:57:58 2026 +0100"
  },
  "committer": {
    "name": "Sean Liao",
    "email": "sean@liao.dev",
    "time": "Fri May 01 09:23:38 2026 -0700"
  },
  "message": "git-codereview: isolate tests from user\u0027s global git config\n\nThe test harness creates ephemeral git repositories via gitTest and\nruns commands like \"git tag work\" without a message. When a user has\ntag.gpgsign or commit.gpgsign enabled in their global git config, those\nsettings are inherited by the test repos and cause failures: signed\ntags require a message, so \"git tag work\" aborts with \"fatal: no tag\nmessage?\".\n\nRather than disable the specific settings that bite us today, set\nGIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM to os.DevNull in trun so every\ntest git invocation runs with no global or system config at all. This\nforecloses the entire class of \"user config leaks into tests\" bugs\n(gpg signing, init.defaultBranch, core.autocrlf, custom hooks, signing\nkeys, aliases, ...) instead of stamping out one symptom.\n\nTradeoffs worth noting for the interested reader:\n\n  - GIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM were added in git 2.32\n    (June 2021), so this raises the minimum git version required to\n    run the test suite. The tool itself is unaffected.\n\n  - trun is also used for non-git commands; setting these env vars\n    unconditionally is harmless because non-git binaries ignore them,\n    and keeping the call site unconditional keeps trun simple.\n\n  - os.DevNull (rather than a hard-coded \"/dev/null\") is used so the\n    isolation works on Windows, where the equivalent path is \"NUL\".\n\nChange-Id: Iafdef28241c81e30cb4f7898da0e5eeb4b7f0872\nReviewed-on: https://go-review.googlesource.com/c/review/+/772280\nReviewed-by: Carlos Amedee \u003ccarlos@golang.org\u003e\nLUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Daniel Martí \u003cmvdan@mvdan.cc\u003e\nReviewed-by: Sean Liao \u003csean@liao.dev\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "931d01751343192c9ff46689cfecad8b97e4e992",
      "old_mode": 33188,
      "old_path": "git-codereview/util_test.go",
      "new_id": "355bc849dbf62d4378c90c6d0cd0c06044efe2c2",
      "new_mode": 33188,
      "new_path": "git-codereview/util_test.go"
    }
  ]
}