| commit | f64da474f58aa878a967c0f87c39747f42fe6b63 | [log] [tgz] |
|---|---|---|
| author | Bryan C. Mills <bcmills@google.com> | Mon Dec 16 10:05:06 2019 -0500 |
| committer | Bryan C. Mills <bcmills@google.com> | Mon Dec 16 19:06:16 2019 +0000 |
| tree | 3651191f3158470b284a11085f74b68d2bf66cd5 | |
| parent | be34946817dcf706c2f9448ebd50102472c552f6 [diff] |
git-codereview: write hooks with execute permission in tests The 'write' helper function previously assumed file permission 0666. We don't actually need these files to be world-writable, but we do need specific ones — scripts executed as Git commit hooks — to be executable, at least on certain platforms. Also use t.Helper() to produce more useful log lines for failures. (That was added in order to diagnose TryBot failures.) Fixes golang/go#32836 Change-Id: I2d670563f42778ef8cf645445420756599c37ac6 Reviewed-on: https://go-review.googlesource.com/c/review/+/211477 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org>
The git-codereview tool is a command-line tool for working with Gerrit.
The easiest way to install is to run go get -u golang.org/x/review/git-codereview. You can also manually git clone the repository to $GOPATH/src/golang.org/x/review.
Run git codereview hooks to install Gerrit hooks for your git repository.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the review repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/review:” in the subject line, so it is easy to find.