commit | b8ead204a2e00eca3f1554da0b908d1d7b7afb9f | [log] [tgz] |
---|---|---|
author | Tobias Klauser <tklauser@distanz.ch> | Fri Dec 03 20:11:11 2021 +0100 |
committer | Tobias Klauser <tobias.klauser@gmail.com> | Fri Dec 03 21:50:33 2021 +0000 |
tree | 9cdf67d000154fb147b0883cb755bd76b4523a01 | |
parent | 4305ba78f05fd75ba1bc3be8457fcc2501da2c5e [diff] |
git-codereview: don't sign git tags For users who set tag.gpgSign=true in their git configuration, git-codereview mail currently fails to create the .mailed git tag because a signed git tag always requires a message: fatal: no tag message? (running: git tag -f foobar.mailed cf87726ac456) /home/tklauser/go/bin/git-codereview: exit status 128 Fix this by overriding the tag.gpgSign configuration using git tag --no-sign. There is no point in having these tags signed as they should never leave the local system. Change-Id: I8b7ddf3aa7709e6ea06e4d5add6cd581e9ec2e37 Reviewed-on: https://go-review.googlesource.com/c/review/+/369194 Trust: Tobias Klauser <tobias.klauser@gmail.com> Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com>
The git-codereview tool is a command-line tool for working with Gerrit.
The easiest way to install is to run go get -u golang.org/x/review/git-codereview
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/review
.
Run git codereview hooks
to install Gerrit hooks for your git repository.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the review repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/review:” in the subject line, so it is easy to find.