| commit | 7744f6d7ac193720bb483dc2a2c266504b33d1a9 | [log] [tgz] |
|---|---|---|
| author | Andrew Gerrand <adg@golang.org> | Mon Mar 25 11:35:57 2019 +1100 |
| committer | Andrew Gerrand <adg@golang.org> | Mon Mar 25 02:02:52 2019 +0000 |
| tree | ee8009a5598eaa5798124ef09af58f12fad81ab4 | |
| parent | 05c26900aa9101b5ab40490ad329fab7dfa56cb6 [diff] |
git-codereview: make commit-msg hook play nicely with other systems Gerrit requires 'Change-Id:' lines to be included in each commit message, but they are not the only kind of 'metadata line' that might appear in a commit message. Metadata lines observed by other systems include 'Bug:' and 'Signed-off-by:'. This change ensures that the commit-msg hook adds its 'Change-Id:' line to the set of metadata lines, separated only by a single linefeed, rather than creating a new set by inserting two line feeds. Change-Id: Ia3bdce6f52f663685eea1e648874ef81ddb2bd91 Reviewed-on: https://go-review.googlesource.com/c/review/+/169097 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The git-codereview tool is a command-line tool for working with Gerrit.
The easiest way to install is to run go get -u golang.org/x/review/git-codereview. You can also manually git clone the repository to $GOPATH/src/golang.org/x/review.
Run git codereview hooks to install Gerrit hooks for your git repository.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the review repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/review:” in the subject line, so it is easy to find.