| commit | 1ee98ad07b3b077731a919d3cf37e7bfc1741fa3 | [log] [tgz] |
|---|---|---|
| author | Dmitri Shuralyov <dmitshur@golang.org> | Wed May 10 08:53:08 2023 -0400 |
| committer | Gopher Robot <gobot@golang.org> | Thu Jun 22 19:53:14 2023 +0000 |
| tree | bced9d1f694e7adbb3a2f1a35415777af96ba134 | |
| parent | d285cae025f6e6848090ddb748aade98677328db [diff] |
git-codereview: fix mail lookup for dmitshur short name CL 2111 introduced a simple algorithm for expanding short user names that works locally and generally doesn't need any extra configuration to do the right thing. It's been serving for almost a decade. Unfortunately I'm running into an edge where I see no good option but to add a special case. Gerrit inserts "Reviewed-by" footers both for Code-Review +2 and +1 votes without any way to distinguish between them, and my @google.com account unavoidably gets more hits since I use it for the go.dev/s/needs-review process, whenever I leave a normal +2, and on my own CLs. The simplest fix seems to be to exclude it from short matches and let the existing algorithm do the rest. Change-Id: I92da69f1cd87b4c89816547015cffbed3eaaeaf6 Reviewed-on: https://go-review.googlesource.com/c/review/+/494175 Reviewed-by: MKaslann1 <mkaslann1@outlook.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
The git-codereview tool is a command-line tool for working with Gerrit.
The easiest way to install is to run go install golang.org/x/review/git-codereview@latest. You can also manually git clone the repository to $GOPATH/src/golang.org/x/review.
Run git codereview hooks to install Gerrit hooks for your git repository.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the review repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/review:” in the subject line, so it is easy to find.