| commit | 0eaa382942a3219dcdf0eb1a5e6a72854ebf7dcd | [log] [tgz] |
|---|---|---|
| author | Russ Cox <rsc@golang.org> | Mon Oct 02 09:19:37 2017 -0400 |
| committer | Russ Cox <rsc@golang.org> | Mon Oct 02 23:47:59 2017 +0000 |
| tree | 6be5263153e9241815e567f1c035e6297c1b5587 | |
| parent | 925f9bd3fb4bf9cda7fef491941894d634b3b535 [diff] |
git-codereview: avoid Gerrit timeout for missing Change-Id during pending If a commit is missing a Change-Id line, pending queries https://go-review.googlesource.com/a/changes/go~master~?o=DETAILED_LABELS&o=CURRENT_REVISION&o=MESSAGES&o=DETAILED_ACCOUNTS (that's go~master~CHANGEID?... with CHANGEID=""), which must cause Gerrit to iterate over all possible CLs or something like that, because it takes forever. Don't bother: if the commit we care about has no Change-Id, it is by definition not on the server at all. This makes 'git pending' not just hang when you have a commit without a Change-Id. Change-Id: I548a51b4190db723538af35ea6a14169861d6bc3 Reviewed-on: https://go-review.googlesource.com/67570 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
The git-codereview tool is a command-line tool for working with Gerrit.
The easiest way to install is to run go get -u golang.org/x/review. You can also manually git clone the repository to $GOPATH/src/golang.org/x/review.
The review binary itself is available at golang.org/x/review/git-codereview. Run git codereview hooks to install Gerrit hooks for your git repository.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the review repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/review:” in the subject line, so it is easy to find.