tree 8f264d359d313cb7b0e60afb5cfdf2a858b8964b
parent 5366f825ad2b934621019da5ceadb00fc94e2e4a
author Damien Neil <dneil@google.com> 1575675363 -0800
committer Damien Neil <dneil@google.com> 1575916513 +0000

all: don't allow invalid field numbers when legacy support is on

The deprecated messageset format permits extension fields with numbers
greater than the usual maximum (1<<29-1). To support this, the
internal/encoding/wire package has disabled field number validation when
legacy support is enabled.

We shouldn't skip validating all field numbers for validity just because
we support larger ones in messagesets.

This change drops range validation from the wire package (other than
checking that numbers fit in an int32) and adds it to the wire
unmarshalers instead. This gives us validation where we care
about it (when unmarshaling a wire-format message) and allows for
best-effort handling of out-of-range numbers everywhere else.

Fixes golang/protobuf#996

Change-Id: I4e11b8a8aa177dd60e89723570af074a317c2451
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/210290
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>