tree 22de0a365359ab451c5b7bb54640cd6c43e6ad10
parent 987d570c08b115222e2347b66a3052f57eb32ee3
author Damien Neil <dneil@google.com> 1554924705 -0700
committer Damien Neil <dneil@google.com> 1554931754 +0000

internal/legacy, internal/encoding/tag: don't synthesize options

Stop adding options to legacy MessageDescriptors and FieldDescriptors.
We would synthesize options messages containing semantic options
(FieldOptions.is_packed, FieldOptions.is_weak, MessageOptions.map_entry).
This information is already contained in the protoreflect descriptors,
so there is no real need to define a correct options message.

If we do want to include options in legacy descriptors, then we should
get the original value out of the FileDescriptorProto, since it may
include additional extensions or other information.

This change completely removes the dependency from internal/legacy to
descriptor.proto.

Change-Id: Ib6bbe4ca6e0fe7ae501f3e9b11d5fa0222808410
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/171458
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>