Google Git
Sign in
go / protobuf / fb30a40376ac80737bcdadf6ff08a2caab24a761
commitfb30a40376ac80737bcdadf6ff08a2caab24a761[log] [tgz]
authorJoe Tsai <joetsai@digital-static.net>Mon May 20 15:19:14 2019 -0700
committerDamien Neil <dneil@google.com>Tue May 21 14:02:32 2019 +0000
tree3fcd59858f6aace85116f57adf13d36aa854a5c3
parentdbab6c06ee2e22fb6e2eb7e4ec0c3a3bc193bf60 [diff]
testing/protobuf: fix float comparison bug

The prior code was comparing a to a, when it should compare a to b.

While we're at it, split the float32 and float64 cases apart to
ensure that the type provided by the implementation under test
really was the right float type. This matches the behavior of the
default case (which check that the types exactly match).

Change-Id: I01b1ff5b7f312a35cc8d1f012f3f747db26379fd
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/178377
Reviewed-by: Damien Neil <dneil@google.com>
1 file changed
tree: 3fcd59858f6aace85116f57adf13d36aa854a5c3
  1. cmd/
  2. compiler/
  3. encoding/
  4. internal/
  5. proto/
  6. reflect/
  7. runtime/
  8. testing/
  9. types/
  10. .gitignore
  11. .travis.yml
  12. AUTHORS
  13. CONTRIBUTING.md
  14. CONTRIBUTORS
  15. go.mod
  16. go.sum
  17. integration_test.go
  18. LICENSE
  19. PATENTS
  20. README.md
  21. regenerate.bash
  22. test.bash
README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.