| commit | f6cf4925a90ea4d1b27a665dbad47289990de912 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Tue Feb 25 11:55:52 2020 -0800 |
| committer | Joe Tsai <thebrokentoaster@gmail.com> | Tue Feb 25 20:33:07 2020 +0000 |
| tree | 8c5b5fa226c5693e1f409d563749ee2d53256f83 | |
| parent | 49f8611134952406c268a4064aadc0b95f83bf3f [diff] |
proto: add TestNil test TestNil checks for panic behavior for all top-level functions that accept messages to ensure that we can detect when behavior changes whether accidentally or deliberately. This test discovered that the pure protobuf reflect behavior differs with the fast-path implementation for a few cases. For the protobuf reflection implementation, we explicitly check for invalid messages in Merge and Reset. Previously, these would not panic if the message was already empty (i.e., had no need to actually set/clear any fields in the receiver message). Change-Id: I571c0a819366bae993ce7c99b05fb4707e55cd3e Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/220958 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.