tree 936ac93944b2ab053bea46c7c6adebb0016b1fdf
parent 969537aa2934b8cb2a418f5822326381fda1f679
author Damien Neil <dneil@google.com> 1583278084 -0800
committer Damien Neil <dneil@google.com> 1583287946 +0000

internal/encoding/messageset: fix decoding of some invalid data

For historical reasons, MessageSets items are allowed to have field
numbers outside the usual valid range. Detect the case where the field
number cannot fit in an int32 and report an error. Also check for
a field number of 0 (always invalid).

Handle the case where a MessageSet item includes an unknown field.
We have no place to put the contents of the field, so drop it. This is,
I believe, consistent with other implementations.

Change-Id: Ic403427e1c276cbfa232ca577e7a799cce706bc7
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/221939
Reviewed-by: Herbie Ong <herbie@google.com>