)]}' { "commit": "e1c61a307e316a986776f22bf96de97e825e2d05", "tree": "936ac93944b2ab053bea46c7c6adebb0016b1fdf", "parents": [ "969537aa2934b8cb2a418f5822326381fda1f679" ], "author": { "name": "Damien Neil", "email": "dneil@google.com", "time": "Tue Mar 03 15:28:04 2020 -0800" }, "committer": { "name": "Damien Neil", "email": "dneil@google.com", "time": "Wed Mar 04 02:12:26 2020 +0000" }, "message": "internal/encoding/messageset: fix decoding of some invalid data\n\nFor historical reasons, MessageSets items are allowed to have field\nnumbers outside the usual valid range. Detect the case where the field\nnumber cannot fit in an int32 and report an error. Also check for\na field number of 0 (always invalid).\n\nHandle the case where a MessageSet item includes an unknown field.\nWe have no place to put the contents of the field, so drop it. This is,\nI believe, consistent with other implementations.\n\nChange-Id: Ic403427e1c276cbfa232ca577e7a799cce706bc7\nReviewed-on: https://go-review.googlesource.com/c/protobuf/+/221939\nReviewed-by: Herbie Ong \u003cherbie@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "55526cf3c58b83ab7e55ee5b6448860291cdd0e5", "old_mode": 33188, "old_path": "internal/encoding/messageset/messageset.go", "new_id": "4bd0e4eb72cb545e70e8b61041303c4385ce0c6a", "new_mode": 33188, "new_path": "internal/encoding/messageset/messageset.go" }, { "type": "modify", "old_id": "ff4134211cdd246d19e647cc5144cad63a0f2627", "old_mode": 33188, "old_path": "proto/messageset_test.go", "new_id": "1eedcc96a24dce581bde7fbdffc1dba351118d60", "new_mode": 33188, "new_path": "proto/messageset_test.go" } ] }