Google Git
Sign in
go / protobuf / dbab6c06ee2e22fb6e2eb7e4ec0c3a3bc193bf60
commitdbab6c06ee2e22fb6e2eb7e4ec0c3a3bc193bf60[log] [tgz]
authorJoe Tsai <joetsai@digital-static.net>Tue May 14 15:06:03 2019 -0700
committerJoe Tsai <joetsai@digital-static.net>Fri May 17 06:27:54 2019 +0000
treed0a65e5a99fd8ddcf35c15860daf9c4df6abb94e
parentc37adefdac3634ee9b6f9494ff75001b93d01c28 [diff]
cmd/protoc-gen-go: generate Enum method even on proto3

A proto2 message can reference a proto3 enum. It is currently cumbersome
to set proto3 enums in proto2 messages. Add the Enum method in all situations
to support this situation. It also removes yet another point of divergence
between proto2 and proto3.

We could consider removing this method if Go ever gets generics,
but that hypothetical future is long ways away.

Change-Id: Ib83bc87e46b49f3271b90bacb2893bb8e278e4f2
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/177257
Reviewed-by: Damien Neil <dneil@google.com>
13 files changed
tree: d0a65e5a99fd8ddcf35c15860daf9c4df6abb94e
  1. cmd/
  2. compiler/
  3. encoding/
  4. internal/
  5. proto/
  6. reflect/
  7. runtime/
  8. testing/
  9. types/
  10. .gitignore
  11. .travis.yml
  12. AUTHORS
  13. CONTRIBUTING.md
  14. CONTRIBUTORS
  15. go.mod
  16. go.sum
  17. integration_test.go
  18. LICENSE
  19. PATENTS
  20. README.md
  21. regenerate.bash
  22. test.bash
README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.