tree 7e75b6d7ea7fc1477dcc27ccc3c3c6e472b754d4
parent a8593bae5761ccb52974c5c8587554258a78eb79
author Joe Tsai <joetsai@digital-static.net> 1546973974 -0800
committer Joe Tsai <thebrokentoaster@gmail.com> 1547018608 +0000

protogen: fix oneof name mangling regression

The generator currently uses an unintuitive and stateful algorithm
for name generation where it "fixes" name conflicts by appending "_"
to the end of the new name.

PR#657 refactored the generator code and noticed that the above
algorithm was not properly taking into account that a Get method is
generated for parent oneofs, fixing it in the same PR. While this is
more correct, this breaks users (see #780) since it means that the
generation of names can change.

This PR changes the name mangling logic to be as it was previously.
This does mean that some new proto files may be unbuildable,
but that is arguably better than breaking existing proto files

Change-Id: I2e354f4bb5d9c2b562fa2faa9149e949e2d86a0f
Reviewed-on: https://go-review.googlesource.com/c/156877
Reviewed-by: Damien Neil <dneil@google.com>