| commit | d56458e71befb075ffd5db3a75fa5b4c08ec94f4 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Fri Mar 01 18:11:42 2019 -0800 |
| committer | Joe Tsai <thebrokentoaster@gmail.com> | Mon Mar 11 19:40:53 2019 +0000 |
| tree | 68a71f4d8c6ab17193241013fcdb35a44b76b3f5 | |
| parent | beda40407075ca3f9620872a580e8809b4b6f9f3 [diff] |
internal/cmd/generate-protos: generate test for testdata Running "go build ./..." does not descend into testdata directories. However, the testdata in this repository is source code that is intended to build properly. We could rename the directory, but that does not test whether the generated packages can initialize properly. Thus, we generate a trivial test that simply blank imports all packages. Doing this reveals that some of the generated files have incorrect imports, leading to registration conflicts. To avoid introducing a dependency on gRPC from our go.mod file, we put the testdata directories in their own module. Also, we avoid running internal/testprotos through the grpc plugin because the servie and method definitions in that directory are more for testing proto file initialization rather than testing grpc generation. Change-Id: Iaa6a06449787a085200e31bc7606e3ac904d3180 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/164917 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.