tree f807e9b76ede51388270ced3a4892a20cccb0852
parent 6e25d8c6a6cdd072e374d152a81c0b04b43ec8c1
author Damien Neil <dneil@google.com> 1566518516 -0700
committer Damien Neil <dneil@google.com> 1566841685 +0000

reflect/protoreflect: add non-allocating Value constructors

Passing a non-pointer type to protoreflect.NewValue causes an
unnecessary allocation in order to store the value in an interface{}.
While this allocation could be avoided by a smarter compiler, no such
compiler exists today.

Add functions for creating new values of a specific type, avoiding the
allocation. (And also adding a small amount of type safety, although
this is unlikely to be important.)

Update the proto and internal/impl packages to use these functions.

Change-Id: Ic733de22ddf19c530189166c853348e1b54b7391
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/191457
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>