| commit | beda40407075ca3f9620872a580e8809b4b6f9f3 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Sun Mar 10 16:40:48 2019 -0700 |
| committer | Joe Tsai <thebrokentoaster@gmail.com> | Mon Mar 11 19:34:12 2019 +0000 |
| tree | 2a95db6e9368639d639559962f7642f7f188eee9 | |
| parent | 0fc224513bfa51ab2efc08057e2ac3897102c338 [diff] |
protogen: drop dependency on golang.org/x/tools/go/ast/astutil To keep the dependency tree of Go protobufs as small as possible, avoid depending on astutil. Most of the complexity of astutil.AddNamedImport was for identifying an existing import block to insert imports into, which is not relevant for our use-case. Assuming that we always create a new import block after the package statement, the logic for doing the AST manipulation is relatively simple. This re-write properly handles an inline comment after the package statement, which astutil.AddNamedImport (see golang.org/issue/30724) currently fails to do. Change-Id: I894e733aa82a241719b6f0c23de8d2fbfb67b778 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/166522 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.