| commit | bda671fa93a50287670feea131146e6ed2827340 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Sat Oct 20 13:15:35 2018 -0700 |
| committer | Joe Tsai <thebrokentoaster@gmail.com> | Mon Oct 22 17:14:19 2018 +0000 |
| tree | 15292cf8fc56d0591f714cbbb4f1b6e5b5439f79 | |
| parent | 2c870bb5cc95ae1dab8dc3c4afb32df95e037516 [diff] |
cmd/protoc-gen-go: re-escape default byte values Historically, protoc-gen-go outputted the escaped form of bytes as provided by protoc verbatim. This behavior is buggy, but nothing really uses this tag since default values are properties of getters instead of serialization. Rather than fixing it, just preserve prior behavior. Otherwise, logic depending on the old legacy behavior will not be able to distinguish between the unescaped or the escaped forms. Furthermore, since protoc-gen-go historically copied the protoc output verbatim, we will need to escape the default bytes in a way that is identical to the CEscape function from strutil.cc of the protoc source code. Change-Id: I0ab55e220ae430dd123ad050406e285788f6cb40 Reviewed-on: https://go-review.googlesource.com/c/143543 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.