Google Git
Sign in
go / protobuf / b0d217f66456abab5dc8c6c5e6fd375d6449c7ef
commitb0d217f66456abab5dc8c6c5e6fd375d6449c7ef[log] [tgz]
authorDamien Neil <dneil@google.com>Mon Jan 06 11:17:07 2020 -0800
committerDamien Neil <dneil@google.com>Mon Jan 06 22:47:37 2020 +0000
tree6b85cb03bcfc1ed62336462869f0a2b68606ec6d
parentb7695fab0d48863fb10455abb5ce80f295872243 [diff]
proto, internal/impl: don't create fast path Size for legacy Marshalers

Implementations of the legacy Marshaler type have no way to efficiently
compute the size of the message. Rather than generating an inefficient
fast-path Size method which marshals the message and examines the
length of the result, don't generate a fast-path at all.

Drop the requirement that a fast-path MarshalAppend requires a
corresponding Size.

Avoids O(N^2) behavior when marshaling a legacy Marshaler that
recursively calls proto.Marshal.

Change-Id: I4793cf32275d08f29c8e1a1a44a193d9a5724058
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/213443
Reviewed-by: Joe Tsai <joetsai@google.com>
4 files changed
tree: 6b85cb03bcfc1ed62336462869f0a2b68606ec6d
  1. benchmarks/
  2. cmd/
  3. compiler/
  4. encoding/
  5. internal/
  6. proto/
  7. reflect/
  8. runtime/
  9. testing/
  10. types/
  11. .gitignore
  12. .travis.yml
  13. AUTHORS
  14. CONTRIBUTING.md
  15. CONTRIBUTORS
  16. go.mod
  17. go.sum
  18. integration_test.go
  19. LICENSE
  20. PATENTS
  21. README.md
  22. regenerate.bash
  23. release.bash
  24. test.bash
README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.