| commit | b02b6d1da58d1f7f5e89005403096970d036618c | [log] [tgz] |
|---|---|---|
| author | Herbie Ong <herbie@google.com> | Tue Jan 07 17:26:43 2020 -0800 |
| committer | Herbie Ong <herbie@google.com> | Wed Jan 08 18:44:43 2020 +0000 |
| tree | 24abf96b94e467bdca28f2130686480ab07a7a57 | |
| parent | b0c26f18687fcd4268640aa6076fcf380c7a3086 [diff] |
internal/encoding/json: fix performance cliff when decoding large integers that will go out of range.
For large positive integers, add check for number of decimal digits
before converting number to plain integer w/o exponent.
If exponent value is large, previous implementation may end up
constructing a large string with lots of zeroes that is not useful as it
will fail later on when called with strconv.Parse{Uint,Int} anyways.
Fixes golang/protobuf#1002.
Change-Id: I65bfad304401e076743853d7501786b7231b083b
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/213717
Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.