| commit | afd3633ce3ba0318ee242e4971734b116f890ae5 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Mon Aug 05 13:20:14 2019 -0700 |
| committer | Joe Tsai <joetsai@digital-static.net> | Mon Aug 05 21:38:46 2019 +0000 |
| tree | 34308cd9b57036c90477ccc071877c82ae0ac0b8 | |
| parent | f98dd98c15bbc3e8accc353f5bff6fca06657a4a [diff] |
internal/impl: defer evaluation of weak reference until actual use Suppose some init logic performs protobuf reflection. If so, it will cause the table-driven logic for protobuf reflection to be initialized. This is problematic for weak fields since we can not be certain that all weak references have been registered at this point in time. This is a fundamental issue with with weak dependencies, since it means that we cannot enforce any ordering constraints on the weak dependency unless we directly import the weakly referenced package (which would defeat the point of weak imports). Alleviate the problem by pushing evaluation of weak reference to actual usage. This does not completely fix the problem, but signifcantly reduces the probability of it being problematic. In general, people should avoid interacting with weak fields at init time. Change-Id: Iebaefddde8cf07b5cd7dee49b7015b05b5428618 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/188980 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.