| commit | af57087245ed29594751a2cd47c3ca4d7fb8dfe9 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Sun Jul 14 23:04:40 2019 -0700 |
| committer | Joe Tsai <joetsai@digital-static.net> | Mon Jul 15 20:39:24 2019 +0000 |
| tree | 73c5ddbe3809837505f0be8cfe167fa0ac824d91 | |
| parent | c51e2e0293388cb210278960154ed5adf3569b3e [diff] |
reflect/protoregistry: provide more informative errors for conflicts The v2 implementation strictly enforces that there are no conflicts at all in the protobuf namespace unlike the prior v1 implementation. This change is almost certainly going to cause loud failures for users that were unknowingly tolerating registration conflicts. We modify internal/filedesc to be able to record the Go package path that the file descriptor is declared within. This information is used by reflect/protoregistry to print both the previous Go package that registered some declaration, and current Go package that is attempting to register some declaration. Change-Id: Ib5eb21c1c98495afc51aa08bd4404bd9d64b5b57 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/186177 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.