| commit | a9940822d46736a7549df80a91d58b010a31ab90 | [log] [tgz] |
|---|---|---|
| author | Damien Neil <dneil@google.com> | Mon Jun 24 12:58:17 2019 -0700 |
| committer | Damien Neil <dneil@google.com> | Tue Jun 25 21:59:46 2019 +0000 |
| tree | bb76db56c5d49800733a3d2a06da05831bc71ca9 | |
| parent | 20aefe9c5e425a7949e845ed5f3cc152d2130eb6 [diff] |
all: remove protoreflect.Message.Len Len looks like it should be O(1), but the need to check for non-zero-length repeated fields makes it at minimum O(n) where n is the number of repeated fields. In practice, it's O(n) where n is the number of fields altogether. The Len function is not especially useful, easily duplicated with Range and a counter, and can be surprisingly inefficient. Drop it. Change-Id: I24b27433217e131e842bd18dd58475bcdf62ef97 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/183678 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.