| commit | a0a54b800581be257b89521074f86b40a3496564 | [log] [tgz] |
|---|---|---|
| author | Damien Neil <dneil@google.com> | Fri Nov 01 15:18:36 2019 -0700 |
| committer | Damien Neil <dneil@google.com> | Tue Nov 05 18:31:30 2019 +0000 |
| tree | 8bdef88331026039493551517601e56fc492631a | |
| parent | ef19a2a994702a4b68d4658b9273a8b0a2616c9d [diff] |
reflect/protoreflect: remove nullability from repeated extension fields Remove repeated extension fields from the set of nullable fields, so that Has reports false and Range does not visit a a zero-length repeated extension field. This corrects a fuzzer-detected case where unmarshaling and remarshaling a wire-format message could result in a semantic change. For a repeated extension field in non-packed encoding, unmarshaling a packed representation of the field would result in a message which Has the extension. Remarshaling it would discard the the field. Fixes golang.org/protobuf#975 Change-Id: Ie836559c93d218db5b5201742a3b8ebbaacf54ed Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/204897 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com> Reviewed-by: Joe Tsai <joetsai@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.