| commit | 96a44732e0b1ca7ffd992bf5ed657345a06a3aac | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Fri Jan 03 19:52:28 2020 -0800 |
| committer | Joe Tsai <joetsai@google.com> | Mon Jan 06 19:37:38 2020 +0000 |
| tree | 662eb878aee5eddc4f0ef2dfc1aea7cca432abf4 | |
| parent | 14ac241a9605054dd8338e08fa5a8c7d9ad20f73 [diff] |
proto: distinguish between invalid and empty messages in Equal The v1 proto.Equal function treats (*Message)(nil) and new(Message) as being different, while v2 proto.Equal treated them as equal since a typed nil pointer is functionally an empty message since the protobuf data model has no concept of presence as a first-class property of messages. Unfortunately, a significant amount of code depends on this distinction that it would be difficult to migrate users from v1 to v2 unless we preserved similar semantics in the v2 proto.Equal. Also, double down on these semantics for protocmp.Transform. Fixes #965 Change-Id: I21e78ba6251401a0ac0ccf495188093973cd7f3f Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/213238 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.