tree bd10f5d1eaddec0edf776148463f81f655264a3d
parent 05d60cda2c5e250a6fa6a20e8c0538edea2b9829
author Joe Tsai <joetsai@digital-static.net> 1544053372 -0800
committer Joe Tsai <thebrokentoaster@gmail.com> 1544152428 +0000

cmd/protoc-gen-go: reduce technical debt

The following TODOs were addressed:
* Consistently collect all enums, messages, and extensions in a breadth-first order.
The practical affect of this is that the declaration order in a Go file may change.
This simplifies reflection generation, which relies on consistent ordering.
* Removal of placeholder declarations (e.g., "var _ = proto.Marshal") since
protogen is intelligent about including imports as necessary.
* Always generate a default variable or constant for explicit empty strings.
The practical effect of this is the addition of new declarations in some cases.
However, it simplifies our logic such that it matches the protobuf data model.
* Generate the registration statements in a consistent order.

Change-Id: I627bb72589432bb65d53b50965ea88e5f7983977
Reviewed-on: https://go-review.googlesource.com/c/152778
Reviewed-by: Damien Neil <dneil@google.com>