commit | e9187326c3ff34525927185944b128a78fdc74c6 | [log] [tgz] |
---|---|---|
author | Damien Neil <dneil@google.com> | Thu Nov 07 15:30:44 2019 -0800 |
committer | Damien Neil <dneil@google.com> | Fri Nov 08 00:29:25 2019 +0000 |
tree | 0b97c5d996f0ad85436634ae0d303ac12e7c183e | |
parent | c7f2beeef028cf1b61be634fafc4a6eaf5d25a8c [diff] |
internal/filedesc: move message options to L1 initialization Avoid a deadlock when registering a legacy ExtensionType, caused by initialization of the "internal/impl".ExtensionInfo calling IsMessageSet on the MessageDescriptor of the type being extended. We can avoid this deadlock either by initializing the ExtensionType outside of the GlobalTypes mutex, or by moving IsMessageSet to L1 initialization of the MessageDescriptor so that it doesn't trigger lazy init. CL 204804 takes the former approach; this CL takes the latter. Change-Id: Idfc1ed36a23a139839290ea32492142a17f68cf5 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/205957 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2:
prefix in the title to make it clear that the issue is regarding the new API work.