tree ee3e72bfd92edf671fe42e19650e42df61bbc035
parent 792d35935175dfd747b1ec1043740a3fc726242a
author Michael Stapelberg <stapelberg@golang.org> 1763383299 +0100
committer Michael Stapelberg <stapelberg@golang.org> 1763390883 -0800

internal/filedesc: remove duplicative Message.unmarshalOptions

A user reported a data race when calling the IsMapEntry and Options accessors
concurrently: https://github.com/golang/protobuf/issues/1701

Originally, I wanted to suggest moving the md.L1.IsMapEntry / md.L1.IsMessageSet
assignments into Message.unmarshalSeedOptions when I realized that these fields
are already set in unmarshalSeedOptions!

Therefore, we can entirely remove Message.unmarshalOptions in favor of
Message.unmarshalSeedOptions. All tests continue to pass, both within Go
Protobuf itself, and also all Google tests (Global Presubmit, cl/832261606).

Resolves golang/protobuf#1701

Change-Id: Ieb4dbddd11f4a123ba01d3c10fed4d16bee0791a
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/720980
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Lasse Folger <lassefolger@google.com>