commit | 8a4c3d18b1c3fe1a333929843a183528c2dee304 | [log] [tgz] |
---|---|---|
author | Joe Tsai <joetsai@digital-static.net> | Sat Jul 06 18:08:55 2019 -0700 |
committer | Joe Tsai <joetsai@digital-static.net> | Mon Jul 08 17:26:50 2019 +0000 |
tree | b72f7cae2cc8fa51e58f09295df57843458e08b4 | |
parent | 93fd968b7178b2bbf6c4eda8acdbcc8858fc1b98 [diff] |
internal/filedesc: avoid deep-copying the options The protoreflect.Descriptor.Options method is currently documented as returning a reference to the options, where the user must not mutate the returned message. This changes internal/filedesc to avoid returning a copy of the options by caching the first unmarshal. See golang/protobuf#877 Change-Id: I15701d33fbda7535b21b2add72628b02992c373f Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/185197 Reviewed-by: Benny Siegert <bsiegert@gmail.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2:
prefix in the title to make it clear that the issue is regarding the new API work.