| commit | 71c6603a26f97eca0b159c67604009610b1f4191 | [log] [tgz] |
|---|---|---|
| author | Damien Neil <dneil@google.com> | Wed Feb 20 16:13:57 2019 -0800 |
| committer | Damien Neil <dneil@google.com> | Thu Feb 21 22:37:58 2019 +0000 |
| tree | 788e37a536254ca677f96e91c1ada7fa6acd8033 | |
| parent | 7b828bca66897f8f89c9677eeaba409c580bcae1 [diff] |
protogen: use full filename in per-file vars For a file "foo/bar.proto", put the FileDescriptor in "ProtoFile_foo_bar" rather than "Bar_fileDescriptor". Avoid name clashes when a package contains "a/foo.proto" and "b/foo.proto". Don't camelcase the filename: These vars weren't fully camelcased to begin with, and leaving the filename relatively unchanged is clearer and more predictable. Move "ProtoFile" from the end of the var name to the start, so that vars will sort better in packages with multiple descriptors. These changes do add a chance of name collision when the input filename begins with an uppercase letter: Foo.proto becomes "ProtoFile_Foo", which could be the result of camelcasing "proto_file.foo". The readability benefits seem worth it. Change-Id: If27d3a0d7b5bf3535aa1607a8579eb057c74d2dc Reviewed-on: https://go-review.googlesource.com/c/163199 Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com> Reviewed-by: Herbie Ong <herbie@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.