| commit | 84f0960b046f4325b5c15cb67b6c6cdf2550131a | [log] [tgz] |
|---|---|---|
| author | Herbie Ong <herbie@google.com> | Thu Jan 17 19:31:47 2019 -0800 |
| committer | Herbie Ong <herbie@google.com> | Fri Jan 18 17:54:23 2019 +0000 |
| tree | 5fe3e5023c506aa82a9b4dc21942192d6937541f | |
| parent | de7313b557a34d156f85c4ec973595568b65ec9c [diff] |
internal/encoding/text: format using 32 bitsize when encoding float32 When encoding/textpb marshals out float32 values, it was previously formatting it as float64 bitsize since both float types are stored as float64 and internal/encoding/text only has one Float type. A consequence of this is that the output may display a different value than expected, e.g. 1.02 becomes 1.0199999809265137. This CL splits Float type into Float32 and Float64 to keep track of which bitsize to use when formatting. Values of both types are still stored as float64 to keep the logic simple. Decoding will always use Float64, but users can ask for a float32 value from it. Change-Id: Iea5b14b283fec2236a0c3946fac34d4d79b95274 Reviewed-on: https://go-review.googlesource.com/c/158497 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.