Google Git
Sign in
go / protobuf / 5b6d0471e5bd463898a8121123ace60c7a0d9ca7
commit5b6d0471e5bd463898a8121123ace60c7a0d9ca7[log] [tgz]
authorDamien Neil <dneil@google.com>Fri Jun 14 11:54:07 2019 -0700
committerDamien Neil <dneil@google.com>Fri Jun 14 22:25:26 2019 +0000
treef4c94f346e3f7e784536ce4ce5d04d5fd2171061
parent05e11b806f927ef0425a3e3f32e6d6792f65bb1c [diff]
internal/impl: handle irregular messages implementing proto.Message

When encountering a type that does not have a MessageInfo, don't assume
that it's a legacy message that doesn't implement proto.Message. Add a
set of test messages exercising this case (panics prior to the
internal/impl change).

Change-Id: Ic1ec5ecfbe92278fbef44284ff52a0e0622a158c
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/182477
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
7 files changed
tree: f4c94f346e3f7e784536ce4ce5d04d5fd2171061
  1. cmd/
  2. compiler/
  3. encoding/
  4. internal/
  5. proto/
  6. reflect/
  7. runtime/
  8. testing/
  9. types/
  10. .gitignore
  11. .travis.yml
  12. AUTHORS
  13. CONTRIBUTING.md
  14. CONTRIBUTORS
  15. go.mod
  16. go.sum
  17. integration_test.go
  18. LICENSE
  19. PATENTS
  20. README.md
  21. regenerate.bash
  22. test.bash
README.md

Next Generation Go Protocol Buffers

WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.

This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.

Design Documents

List of relevant design documents:

Contributing

We appreciate community contributions. See CONTRIBUTING.md.

Reporting Issues

Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.