tree 66b2d487d28b410ffcda64410f88a3d09ed18eab
parent 95539ea04c0bc300e7472d522466184168b1f430
author Joe Tsai <joetsai@digital-static.net> 1567152042 -0700
committer Joe Tsai <joetsai@digital-static.net> 1567543355 +0000

internal/filedesc: fix dependency on legacy generated enums

Suppose you have a generated message with an enum field that
has a default value, where the enum is declared in another proto file
that does not register its descriptors.
In such a situation, the enum dependency cannot be resolved and will
be left as a placeholder.

When unmarshalDefault is called, it will attempt to parse the enum
name stored as the default value, but panic since the placeholder enum
has no enum values known to it.

Instead of panicking, use a placeholder enum value that preserves the
name of default enum value and just use the enum number of 0.
This is not ideal, but is a better alternative than panicking.

Change-Id: I5ff6c351adbdd6fe7b41f2d4f215be4aa09e751f
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/192500
Reviewed-by: Damien Neil <dneil@google.com>