| commit | 50f860a45aab349ba28cd807e6864cd6c5cae444 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Fri Aug 30 01:00:42 2019 -0700 |
| committer | Joe Tsai <joetsai@digital-static.net> | Tue Sep 03 20:42:35 2019 +0000 |
| tree | 66b2d487d28b410ffcda64410f88a3d09ed18eab | |
| parent | 95539ea04c0bc300e7472d522466184168b1f430 [diff] |
internal/filedesc: fix dependency on legacy generated enums Suppose you have a generated message with an enum field that has a default value, where the enum is declared in another proto file that does not register its descriptors. In such a situation, the enum dependency cannot be resolved and will be left as a placeholder. When unmarshalDefault is called, it will attempt to parse the enum name stored as the default value, but panic since the placeholder enum has no enum values known to it. Instead of panicking, use a placeholder enum value that preserves the name of default enum value and just use the enum number of 0. This is not ideal, but is a better alternative than panicking. Change-Id: I5ff6c351adbdd6fe7b41f2d4f215be4aa09e751f Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/192500 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.