| commit | 4532dd79698a88b12d7287e2194e717cc5f47fd4 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Tue Mar 19 17:04:06 2019 -0700 |
| committer | Joe Tsai <thebrokentoaster@gmail.com> | Thu Mar 21 17:47:49 2019 +0000 |
| tree | fc7d75d91e149abe53197ba91e002dd3df75f360 | |
| parent | 300cff08c7da09260e83f865718bcee831aed9e4 [diff] |
internal/fileinit: prevent map entry descriptors from implementing MessageType The protobuf type system hacks the representation of map entries into that of a pseudo-message descriptor. Previously, we made all message descriptors implement MessageType where type descriptors had a GoType method that simply returned nil. Unfortunately, this violates a nice property in the Go type system where being able to assert to a MessageType guarantees that Go type information is truly associated with that descriptor. This CL makes it such that message descriptors for map entries do not implement MessageType. Change-Id: I23873cb71fe0ab3c0befd8052830ea6e53c97ca9 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/168399 Reviewed-by: Damien Neil <dneil@google.com>
WARNING: This repository is in active development. There are no guarantees about API stability. Breaking changes will occur until a stable release is made and announced.
This repository is for the development of the next major Go implementation of protocol buffers. This library makes breaking API changes relative to the existing Go protobuf library. Of particular note, this API aims to make protobuf reflection a first-class feature of the API and implements the protobuf ecosystem in terms of reflection.
List of relevant design documents:
We appreciate community contributions. See CONTRIBUTING.md.
Issues regarding the new API can be filed at github.com/golang/protobuf. Please use a APIv2: prefix in the title to make it clear that the issue is regarding the new API work.